It would be nice for multilingual sites to have the same feature as in the parent module:
see #330165.

further if the 'Subscribe to ' is moved out of the single newsletters and put as introduction (as done in the parent module) then the same translations can be used for both modules.

CommentFileSizeAuthor
#1 simplenews_register.i18n_register_user.patch5.66 KBxibun

Comments

xibun’s picture

xibun commented
Status: Active » Needs work
StatusFileSize
new simplenews_register.i18n_register_user.patch5.66 KB

here a suggestion based on the patch of the parent module.

-> it seems to work on my configuration - but it's my first Drupal code - please inspect carefully.
-> also I don't like the fact that a small change aside it repeats a big junk of code three times - I'm sure that could be done in a nicer way.

moonray’s picture

moonray commented
Status: Needs work » Fixed

I modified the patch to be more efficient and not repeat any code. It's been added to CVS.

xibun, can you please verify it's working as expected?

xibun’s picture

xibun commented

looks much better.

It works perfectly on my configuration.
I'm using "Localize terms.", other translation modes not tested.

xibun’s picture

xibun commented

couldn't resist to do more testing..

- Taxonomy translation mode "None." works too.
- when set to "Per language terms." no newsletters are offered in any language - but the same happens in the parent module (=simplenews) when editing an active profile. so either this is a problem in both modules or a local problem in my configuration. I'm not sure what the "Per language terms." option is good for so the latter seems more likely to me.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.