Tax line items need to be kept consistent throughout the workflow

On the 2.x Livetest, I setup a tax rate that adds a 6% sales tax to shippable products and shipping line items. I setup a second tax rate that adds a 6% sales tax to any product, shipping line items, and other tax line items. This second is added after the first. On the checkout form, the second one is $0.05 more to account for taxing the tax. However, on the review page, the second one is $0.10 more like it's taxing itself.

Failed to apply.

This worked for a normal tax line item, a second tax line item taxing tax line items, and a third line item taxing tax line items... if anything should've confused it, it would've been that. And I don't think anything is quite as complex in real life. I hope. : P

I guess it's good to go!

Hi --

I'm wondering if I'm doing something wrong, but with this patch (or the latest version of the module), I'm getting duplicate tax line items if I visit the cart/checkout/review page more than once.
that is:
- go through the checkout process to the review page
- press back to go cart/checkout
- press review again to go to cart/checkout/review

Each time I go to the review page from the checkout page, my tax line items are duplicated.
I can fix the issue by changing uc_taxes.module like so:

uc_taxes/uc_taxes.module	2009-02-24 18:02:58.000000000 -0500
@@ -378,6 +378,7 @@
   if (is_array($order->line_items)) {
     foreach ($order->line_items as $i => $line) {
       if (substr($line['type'], 0, 3) == 'tax' && substr($line['type'], 4) != '_subtotal') {
+        uc_order_delete_line_item($line['line_item_id']);
         unset($order->line_items[$i]);
       }
     }

That is, I delete the line item from the DB in addition to unsetting it. Does that make sense?

Thanks.

Tested on the Livetest... taxes calculating fine during and after checkout. Committed that attached version, as the previous patch was not good after committing a separate tax patch earlier.

tagging

These patches do not work. I also tested with latest BETA5 code without patching. Still getting duplicate taxes, when I go "back" and then "review order" again. Have "weight" set to 10 for this tax item. Also, the tax on the first time through does not reflect line items like discounts etc. It only adds these line items into the mix after a "back" and then "review order" -- but then there are dupes! Two bugs really.

Maybe I applied the patches wrong? Do I apply #10 and then #11? Applying #10 by itself seems to solve the dupe issue. But, the taxes are still out of state, the order object is stale. This is still happening for discounts (various discount modules). The taxes don't take the discount line items into considerations. If you check the order object before calculating taxes, it should fix it.

There was a tax patch committed that invalidated #10, so I applied #11 after the prior one was committed. At this point, I'm not sure where your install is. #11 was done on the latest bzr code and committed... any chance you can grab that? I'm also not sure which discount module you're using. Any more info?

Ok, I'll grab bzr and test. uc_coupons was fixed by the developer, but uc_discount, uc_discounts and uc_discounts_alt all have the problem with tax calculation because they use hook_order. But the order object is stale. Look at the link I posted, comment #4 and you'll see the fix. It would be cool if somehow a fix could happen in uc_taxes which would try and grab the totals after all line items are written to the order object. I think the discount line items are getting written to the database, but the order object used by uc_taxes is stale. Not sure how, yet.

See comment #4 here for what fixed uc_coupon and taxes:

http://drupal.org/node/350359

Ok, I just removed all discount modules and tried the latest uc_taxes folder and file from bzr. No dice. If you go "back" from the review order screen and then continue to review order, you get two dupe tax line items. This scenario would happen if user was on the review order screen and wanted to go back and change some data.

worked for me when using bzr version and applyin the patch from #11.

regards

Ok, I just got the latest from bzr and applied patch #11. Seems to work! Thanks Ryan and Lyle.