Project:Webform Report
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

We want to use webform report to show users their own results, but not results of others. Adding the ability to filter by 'Current User' as an option to the 'User' key could have been an option, but this didn't make sense for our needs because we still want to sort by another column (date) and you can only filter and sort by the same key. So I added two new permissions: "access own webform results in reports" and "access all webform results in reports". Now, users with the first permission can only view their own results, and users with the 2nd permission can view all results. Proposed patch coming next :)

Comments

#1

Status:active» needs review

Actually this patch also contains the 'remove u' patch, and adds a destination to the 'edit' link (another feature that helps UI). I can roll a new patch with only the above changes if needed.

AttachmentSize
webform_report_377468_view_own_results.patch 3.93 KB

#2

Hello,

Thanks for this. This is what I've been looking for.

But how do I install this patch?

#3

hi shaneoj, check here: http://drupal.org/patch/apply

This patch is simple, so if you run into trouble patching you could do it manually... go through the patch line by line, deleting every line that starts with a '-', and adding every line that starts with a '+' (just remember to remove the + sign once you add the lines).

Learning how to apply patches is a good idea though in general... and comes in handy with more complex patches that are difficult to apply manually :)

#4

Thanks!

By the way, does this also work for Drupal 5?

#5

Great feature, thanks!

I want to propose another important option -> to enable a hide field from report.
e.g.: In my Webforms, people send their email & phone#, but these private fields should not show on the general report that everyone will see - the Results option, instead they should only be accessible by the site administrator or someone with permission of access hidden fields.

#6

When I apply the patch I get this message, what does it mean ?

patching file webform_report.inc
Hunk #1 FAILED at 98.
Hunk #2 FAILED at 252.
Hunk #3 FAILED at 312.
3 out of 3 hunks FAILED -- saving rejects to file webform_report.inc.rej
can't find file to patch at input line 53
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|Index: webform_report.module
|===================================================================
|RCS file: /cvs/drupal-contrib/contributions/modules/webform_report/webform_report.module,v
|retrieving revision 1.2.2.55.2.37
|diff -u -p -r1.2.2.55.2.37 webform_report.module
|--- webform_report.module      28 Oct 2008 13:45:38 -0000      1.2.2.55.2.37
|+++ webform_report.module      19 Feb 2009 22:17:56 -0000
--------------------------
File to patch:

#7

Status:needs review» needs work

If you don't mind, could you make a patch for the current CVS?

#8

Status:needs work» closed (won't fix)

#9

Version:6.x-1.x-dev» 6.x-2.x-dev

Is there a way to do this for the 6.x-2.x-dev?