I found two things that look like bugs in the hook_nodeapi. On $op delete it looks like there's a missing = that will foul things up pretty bad. On $op insert and update it seems like the changes to personal book status are only applicable when on the root book node, which is what book_manager_make_personal is expecting as a parameter.

It looks to me like these bugs would completely mess up the personal book status of books, so marking critical.

CommentFileSizeAuthor
book_manager-nodeapi.patch2.17 KBjody lynn

Comments

marcp’s picture

marcp commented
Title: hook_nodeapi bugs » hook_nodeapi('delete') can corrupt the book_manager table
Status: Needs review » Fixed

Thanks for reporting this. The 'delete' case was horrible -- I committed the fix for that. The 'insert' and 'update' cases should get fixed too, but they aren't as bad since book_manager_make_personal() checks the "bookness" of the node.

I'm setting this to 'fixed' because the module needs to undergo a bit more of an overhaul which will address the rest of the hook_nodeapi() issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.