Closed (fixed)
Project:
Event
Version:
5.x-2.x-dev
Component:
Basic Event
Priority:
Critical
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
16 Nov 2005 at 02:40 UTC
Updated:
3 Dec 2005 at 02:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
drewish commentedThe current basic node is pretty broken. At a minimum, you'll need to replace event_node_name() with:
There's a bunch of code for the location module that seems un-needed, the location module should be able to do the same thing by way hook_nodeapi().
I'll roll a patch that cleans out all the borked stuff.
Comment #2
drewish commentedHere's the patch, it pretty much replaces the old module. Let me know if it works for you.
Comment #3
killes@www.drop.org commentedThe current basicevent is the result of me too much listening to certain people. ;)
There was a lengthy discussion leading to this being in cvs. I still am wondering why I did that.
The original issue is here:
http://drupal.org/node/27053
Your patch looks like it would make the basicevent module more like the other suggestions (no location etc). Care to look at those and see if there are good ideas hiding in them? In either case, please commit this patch (and respond to any issues that might come up wrt it ;).
People who want to have an event type that integrates with location.module should make a event_location module and maintain that in parallel.
Comment #4
drewish commentedI'll take a look at them. I got the feeling that the module was designed for 4.6.
I've been using this version of basicevent with the CVS version of location module and it works great. You have to enable it in the content types screen but it works fine. It seems like the new forms API has made the modules much more... modular ;)
Do you want to do a branch of the module for 4.6?
Comment #5
killes@www.drop.org commentedThe idea was to have this for 4.6 too, yes. Can you just pick one of the non-locale enabled versions which would not require an upgrade path and add that for 4.6?
Comment #6
drewish commentedI've commited the patched version to CVS.
gtcaz, go ahead and update your version of the module. You'll need to make sure that:
* the basicevent module is enabled (on the admin/modules page)
* the event node is shown in the calendar (on the admin/settings/content-types/event page)
If you're still having problems, you can switch this issue's status back to active.
Comment #7
drewish commentedComment #8
(not verified) commented