Currently you can only put form elements into the 'Workflow' fieldset, which is quite limiting. This patch adds in some recursive merging of form arrays to allow elements to be added anywhere.

CommentFileSizeAuthor
#13 node_options_2.patch4.29 KBdrumm
#11 node_setings.patch1.79 KBchx
#6 node_options_1.patch5.56 KBdrumm
#1 node_options_0.patch4.34 KBdrumm
node_options.patch6.42 KBdrumm

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new node_options_0.patch4.34 KB

And here is a patch without extra half-finished cruft from Amsteram.

crunchywelch’s picture

crunchywelch commented

nice, I was wanting to do this today actually. +1 from me on visual review ;)

moshe weitzman’s picture

moshe weitzman commented

does form_alter hook not provide a solution?

drumm’s picture

drumm
he/him
Location NY, US
commented

Either we should completely remove this hook and use form_alter() for everything or go with the modification to the hook to make it work completely. I beleive using the hook makes things more readable, but I'd like to hear from some others.

adrian’s picture

adrian commented

+1

we use array_merge_recursive on the node form.

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new node_options_1.patch5.56 KB

Here is a new patch which removes hook_nodeapi('settings', ...) entirely.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

hmm looks nice.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Active

Committed to HEAD. Not marking 'fixed' until this change has been documented.

gerhard killesreiter’s picture

gerhard killesreiter commented 
function upload_form_alter($form_id, &$form) {
  if (substr($form_id, -14) == '_node_settings') {
    $form['workflow']['upload_'. $node->type] = array(
      '#type' => 'radios', '#title' => t('Attachments'), '#default_value' => variable_get('upload_'. $node->type, 1),
      '#options' => array(t('Disabled'), t('Enabled')),
    );
  }
}

How is that supposed to work? $node is undefined.

killes@www.drop.org’s picture

killes@www.drop.org commented
Category: task » bug
Priority: Normal » Critical

Setting to critical bug, this simply does not work.

chx’s picture

chx commented
Status: Active » Needs work
StatusFileSize
new node_setings.patch1.79 KB

This is node module patch, the other modules need similar changes.

drumm’s picture

drumm
he/him
Location NY, US
commented

Good point. I can make a new patch (we don't need $node anyway) on Monday.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review
StatusFileSize
new node_options_2.patch4.29 KB

Here is a complete fix.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to HEAD. Thanks.

drumm’s picture

drumm
he/him
Location NY, US
commented

The converting 4.6 -> HEAD and hook documentation are now updated.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)