Doesn't work with private downloads

Though I haven't thoroughly tested it, I would think that File Force would work with private downloads enabled. Could you be more specific about what's not working?

Sorry, no. I've been cramming on other projects lately… It may be a while before I'm able to.

I'm really interested in private download too !

Hi Guys,

I really need to get this working for a customer, so I hack the code myself and succeded to do it !

How to get it working:

1) Edit the file "includes/file.inc"
2) Replace the function file_download() by this one:

function file_download() {
  // Merge remainder of arguments from GET['q'], into relative file path.
  $args = func_get_args();
  $filepath = implode('/', $args);	

  // Maintain compatibility with old ?file=paths saved in node bodies.
  if (isset($_GET['file'])) {
    $filepath =  $_GET['file'];
  }

if (variable_get('file_downloads', FILE_DOWNLOADS_PUBLIC) == FILE_DOWNLOADS_PRIVATE) {
  $tmp = explode("/",$filepath);
  $filepath = file_directory_path()."/".array_pop($tmp);
  unset($tmp);
}


  if (file_exists(file_create_path($filepath))) {
    $headers = module_invoke_all('file_download', $filepath);
    if (in_array(-1, $headers)) {
      return drupal_access_denied();
    }
    if (count($headers)) {
      file_transfer($filepath, $headers);
    }
  }
  return drupal_not_found();
}

3) Enjoy
4) I've included the patch. This is the first one, I'm sure it's not the best, but at least, I'm trying ;)

Update ! Small bug fix

Replace the function includes/file.php::file_download() (near line 840) by this one:

function file_download() {
  // Merge remainder of arguments from GET['q'], into relative file path.
  $args = func_get_args();
  $filepath = implode('/', $args);

  // Maintain compatibility with old ?file=paths saved in node bodies.
  if (isset($_GET['file'])) {
    $filepath =  $_GET['file'];
  }

  if (variable_get('file_downloads', FILE_DOWNLOADS_PUBLIC) == FILE_DOWNLOADS_PRIVATE) {
    $filepath = file_directory_path()."/".array_pop(explode('system/files/',$filepath));
  }

  if (file_exists(file_create_path($filepath))) {
    $headers = module_invoke_all('file_download', $filepath);
    if (in_array(-1, $headers)) {
      return drupal_access_denied();
    }
    if (count($headers)) {
      file_transfer($filepath, $headers);
    }
  }
  return drupal_not_found();
}

Ack! Don't hack core!

Yes we don't have to hack in the core.

But here, without those 3 lines, all the modules that implement file_download() will never be used !

These are the 3 lines of code to add:

  if (variable_get('file_downloads', FILE_DOWNLOADS_PUBLIC) == FILE_DOWNLOADS_PRIVATE) {
    $filepath = file_directory_path()."/".array_pop(explode('system/files/',$filepath));
  }

It's impossible to do it in an other way!

So... what to do ?

I committed the patch to core.

It's related to file_force but it's a small bug in file_download()

Link: #432332: Private path and file_download

so it is fixed? because the issue is still open.

Hey,

It appears that that patch has never been accepted :( let's see what I can do to help with this.

Cheers

Hey there,

All right, I looked into what's going on here and have a pretty good idea of what needs to be done. But first, here's a small overview of how the download system works in Drupal:

The "download method" setting has an effect on only one place - the file_create_url function in includes/file.inc. If you set this to "public", the urls will be generated as real file paths, but if you set this to "private", 'system/files/' will be prepended to the file name. What this does is make sure that the file isn't fetched straight away, but that you are redirected to the 'system/files/' page, which is a usual menu callback defined in system.module. Now all this callback does is send the file received as the argument to "file_download", which subsequently calls the hook_file_download hooks all over the place.

So long story short: the way file force was designed until now, it was basically just emulating the "private" download method, just instead of the 'system/files/' menu item, it was using 'download/'. "Public" download method practically doesn't exist anyway anymore if you prepend 'download/' to your file path.

So what this means is that for this module to move forward, and allow more configurable download settings for different fields etc. we need to respect the underlying system (unfortunately, there is no hook to rewrite the system/files url) and build on top of that. So from the next release:
1. File Force will only work if the "private" download method is selected.
2. There will be additional view options for Views and Templates to automatically generate file_force URLs for your selected field.
3. To set file_force manually for a selected file of your choice, you will need to append "download=1" query to your link.

Just wanted to share what I learned today, updated module coming up soon :)

Cheers,
Martin

All fixed up and ready to use in the -dev, which should be online within 12 hours.

Apologies for yet another file path change, but that was really needed to make this module applicable all across the board.

Cheers