Project:Video Filter
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The following patch hides the related videos displayed on youtube films. This is the default option for emfield. But this module is better since it allows to embed videos in the middle of the post.

AttachmentSize
video_filter.codecs.inc_.patch670 bytes

Comments

#1

Version:6.x-2.4» 6.x-2.x-dev
Status:needs review» reviewed & tested by the community

@levavie: Nice work :) I want to mark RTBC - the patch above is against 6.x-2.4, so needs to be updated.

Rerolling against 6.x-2.x-dev

AttachmentSize
video_filter_378148_1.patch 809 bytes

#2

Status:reviewed & tested by the community» postponed (maintainer needs more info)

I wonder if we should make this a setting? I'm not sure, but if we change this now, when people are 'used' to having related content show up, some might be surprised.

#3

@blackdog I fully agree. Do you have any preferences for where / how this should be configured? I assume this is only for youtube, just a new variable like variable_set('video_filter_related', 1) defaulting to 'Show related videos'?

#4

@scottrigby - Yeah, something like that would be great.

#5

Status:postponed (maintainer needs more info)» needs review

@blackdog how's this?

AttachmentSize
video_filter_378148_5.patch 2.15 KB

#6

Status:needs review» fixed

Committed. Thanks!

#7

Sweet!

#8

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.