Hi,

Love this module!

This would be a nice to have:

For nodes that have more than one page of comments, it would be great if the comment link in the notification email also contained the page the comment is on (in addition to the comment anchor link).

Thanks,
Mike

CommentFileSizeAuthor
#3 watcher-comment-page.patch1.1 KBmpaler

Comments

solipsist’s picture

solipsist commented

Good idea! I'm keeping it for version 2!

solipsist’s picture

solipsist commented
Status: Active » Postponed
mpaler’s picture

mpaler commented
Status: Postponed » Patch (to be ported)
StatusFileSize
new watcher-comment-page.patch1.1 KB

Hi,

I've managed to get this going on my 5.x installation. Attached is a patch with my mods...

Mike

solipsist’s picture

solipsist commented

Nice, but this will always point to the last page of comments. Someone may have replied to an earlier comment and the comment in reply may be on the first page of comments. Because of that you need to recursively back track up the tree of comments to get the ordered sequence number of the comment the notification is about and then derive its page number. Also, we need to be able to take care of reverse date order for comments (latest first).

mpaler’s picture

mpaler commented

Oh jeez, you're right. How selfish of me: I didn't even think of that because I'm forcing my forum to be Flat list - expanded & oldest first so new comments are always on the bottom...

I'm afraid I'm super swamped right now -- Hopefully later this week I can can give this some more thought. However, this may prove to be a much bigger problem than I bargained for.

Mike

solipsist’s picture

solipsist commented

I had a sense it was a tricky one, why I've delayed implementing it. If you can come up with a patch that implements this in a way that works with what I wrote above, I could add it straight away. When patching, please use the latest version from CVS rather than the releases on the project page.

solipsist’s picture

solipsist commented
Status: Patch (to be ported) » Needs work