Your theme is close to XHTML 1.0 Strict. Are you considering changing the doctype?

page.tpl.php has to print $head, as explained at http://d-theme.com/grassland, then the doctype could be changed.

WCAG validation is also close. The demo page that I tested has only one conflicting link that passes most tests and fails the Cynthia Says WAI test. The page content contains a link to grasslands at drupal.org and your page heading also contains the same text but in a link back to the page. None of the themes have the page heading, in this case Grasslands, linking back to itself.

Comments

ipwa’s picture

ipwa commented
Title: XHTML 1.0 Strict with just a few small changes » WCAG validation

Hey peterx, first off thanks for helping me maintain the queue and testing out my theme. I ported this theme very quickly as you can probably see from some of the markup it still has some WP classes like widgets that I want to change when I get a little more time.

I have changed the doctype now, you can download the new release in up to 12 hours, I just committed some updates. I'll look into WCAG validation when I get some more time.

Cheers

peterx’s picture

peterx commented

http://d-theme.com/grassland has the Feb 24 update and the following error. There is also overlapping text which may be this span.

The W3C test points to the following error. Spans cannot contain block level elements including divisions. The span has to change to a division.
<span class="post-frame-top"><div id="block-user-0" class="block block-user">

peterx’s picture

peterx commented

The CSS validation says:
URI: http://d-theme.com/sites/all/themes/grassland/style.css?3
180 .wp-caption Property -moz-border-radius doesn't exist : 5px
181 .wp-caption Property -webkit-border-radius doesn't exist : 5px
182 .wp-caption Value Error : background-color Lexical error at line 182, column 27. Encountered: "c" (99), after : "$" :colour_post_highlight;
183 .wp-caption Value Error : background-color Parse Error }

ipwa’s picture

ipwa commented

I'll fix this in the next dev release, the encapsulating span of the content top area has a fixed height I'll also change it into a div instead of a span, but this is a different issue.

ipwa’s picture

ipwa commented

I don't think this is being used really so I'll take it out, I want to clean and organize all the CSS but don't have a whole lot of time right now.

peterx’s picture

peterx commented

The March 11 version contains the following line. The end tag needs to be a div.
<div class="post-frame-top"><?php print $content_top; ?></span>

There is a style that really needs to be a class:
<div style="clear: both;">

You can then get to AAA level validation.

ipwa’s picture

ipwa commented

Hey peterx! Thanks a lot for catching this, whooops, lol. I have just committed these changes so should be fixed in next dev release.

peterx’s picture

peterx commented

You are quick with the updates. March 12 makes the theme pass XHTML validation plus WCAG (WAI) from levels a throught to AAA. The CSS validates as CSS 2.1 and 3. Wave detected 1 accessibility error, a heading level 2 that is empty. The following site slogan could drop the h2 element when the slogan is empty.
<div class="slogan"><h2></h2></div>

ipwa’s picture

ipwa commented

Hey peterx, great news! I have added if statements for title and slogan, so the above issues should be solved.

Is this still an issue?

The demo page that I tested has only one conflicting link that passes most tests and fails the Cynthia Says WAI test. The page content contains a link to grasslands at drupal.org and your page heading also contains the same text but in a link back to the page. None of the themes have the page heading, in this case Grasslands, linking back to itself.

I think its the only thing I haven't had a look at. I'm assigning this issue to you since you know more about this issue than I do, and you can close it when you think its ready. After this is closed I'll fix some of the other issues quickly and try to have a stable 1.0 release soon. Cheers!

peterx’s picture

peterx commented
Status: Active » Closed (fixed)
ipwa’s picture

ipwa commented
Status: Closed (fixed) » Fixed

Thanks peterx have added the validation information on the project description.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.