Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I cleaned up some test pages from the handbooks today. While doing so after hitting the delete button, I was presented with refresh and informed by way of $message that I needed to fill out the log message. This seems unnecessary to fill out a log message that will be deleted with the node anyway?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 378658-Revisions-2.patch | 938 bytes | mgifford |
| #7 | 378658-Revisions.patch | 784 bytes | webernet |
Issue fork drupalorg-378658
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #1
gábor hojtsyRight. The code for this lives in the drupalorg project: in DRUPAL-6--1 in drupalorg.module and in HEAD in drupalorg_handbook.module. Both needs to be fixed, so it will be fine now (DRUPAL-6--1) and after the redesign (HEAD) as well.
Comment #2
webernet commentedThis is rather annoying...
Comment #3
sepeck commentedWould it be possible to write the log messages to the User Activity Log? Deletes being a destructive act, I can see this as being valuable to review delete actions not just for Drupal.org but other multi-user sites.
Comment #4
gábor hojtsyAny patches against the drupal.org module, where this was implemented are welcome!
Comment #5
dman commentedI have no idea about the code involved, but being required to add a log message when deleting sounds like a really good feature!
Of course, not so much if the message gets deleted along with the node, but as a workflow thing it sounds sensible - even if the current situation is not by design - or in fact broken
Comment #6
webernet commentedWould something like this work?
Comment #7
webernet commentedComment #8
avpadernoIt would be good if the log message would be passed to
watchdog(); in this way it would be possible to track who deleted the page, and why. Should not it better to log a message when deleting any kind of nodes?Comment #9
avpadernoComment #10
mgiffordI think this will work in D7. I added a watchdog message too for general tracking of the handbooks.
Comment #11
drummThis also applies to the new documentation pages.
Comment #12
avpadernoShould the patch still change the code for book nodes? Book nodes are not used anymore for documentation pages.