group-type basis settings get lost

I'm trying this (against -dev, with .module changed to the linked file above):

------------------------
$ patch < og_read_only.patch
patching file og_read_only.install
patching file og_read_only.module
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file og_read_only.module.rej
$ cat og_read_only.module.rej
*************** function og_read_only_form_node_type_for
*** 202,209 ****
*/

function og_read_only_form_node_type_submit($form, &$form_state) {
- $save[$form_state['values']['type']] = array_filter($form_state['values']['og_read_only_master_types']);
- variable_set('og_read_only_master_types', $save);
}

/**
--- 202,210 ----
*/

function og_read_only_form_node_type_submit($form, &$form_state) {
+ $master_types = variable_get('og_read_only_master_types', array());
+ $master_types[$form_state['values']['type']] = array_filter($form_state['values']['og_read_only_master_types']);
+ variable_set('og_read_only_master_types', $master_types);
}

/**

-----------
Hint?

Thanks, I got it to work. I'm new to Drupal and learning. I do not understand what it is the patch is for, so I cannot test if it works. What type of updating removed the settings?

I have two custom content types that can be posted in groups, info and photos. I want one to be read-only (info).

Both are listed on the OG settings for both types. I can change settings for both, and no settings disappear. However, on the photos type, the checkbox for info is not marked when it is changed in the info page.

Also, info content can be posted by non-admins for groups. When I mark photos as read-only, they too can still be posted.

When making info and photo types read-only for a single group, it works fine.

Ok, wouldn't it make more sense to only show the read-only setting for the content type currently being edited, than the settings for all content types?

What I tried to describe in #4 is that the basic module works for me, but I cannot get your patch to work.

Great, now I finally understand! (I think...)

I was supposing the interface worked in a completely different way, and was not careful to read the text.

So, at the content type settings page for a content marked as group node, that is where the settings for group posts have an effect, nowhere else. This works for me now, also when another content type has been changed! Thanks, extremely useful for me. Sorry for the trouble.

Fixed in branch DRUPAL-6--2. Thanks !