Needs review
Project:
Omniture Integration
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Feb 2009 at 00:37 UTC
Updated:
23 Jul 2012 at 15:38 UTC
Jump to comment: Most recent file
Comments
Comment #1
kristen polI'm not seeing where I can edit the original issue body. The final part of my message got messed up since there was html in there, so here it is again:
It was also complaining about <a> and <img> in the <noscript> so maybe those aren't allowed in there.
Comment #2
nicholas.alipaz commentedCame here looking for this issue. These errors are seen when using a strict doctype.
This module should output xhtml valid code.
The offending lines:
Comment #3
yang_yi_cn commented+1 for all the above
Comment #4
sperks commentedIt is worth keeping in mind that HTML validation tools are just that, tools, and achieving fully validated HTML is not more important than delivering intelligent, well thought out HTML.
That said, D6's default theme comes with DOCTYPE strict, rather than the more past/future friendly HTML5, so my suggestion would be:
languageattributenoscriptThe language attribute is depreciated
The border attribute is depreciated (an OLD safeguard to stop the pretty blue border from appearing on images within an anchor tag, which Drupal's default.css (
img { border: 0; }) takes care of).Validation is important to some, so if only to placate the people who like to add the "This site validates" image on their site, add the div so the
noscripterror disappears - I have NEVER seen a logical explanation for why the noscript thinks it needs this, but while we have DOCTYPE strict in D6, and the validating tools expect it.Comment #5
gregglesBetter statuses. I'm not really in a position to test/review this, but if a consensus forms among users I would be happy to commit.
Comment #6
sperks commentedThe attached patch should validate strict