'access callback' should be defined inside function 'tac_lite_user' for $op = 'categories'. Without it, it causes problems with i18n - tab 'Taxonomy-based access' inside 'My Account' is visible for all users.

CommentFileSizeAuthor
category_access_callback.patch606 byteskndr

Comments

kndr’s picture

kndr
he/him
Primary language Polish
Location Rybnik, Poland
commented
Status: Active » Needs review
Dave Cohen’s picture

Dave Cohen commented
Status: Needs review » Fixed

Thanks, just checked this into DRUPAL-6--1. Could have sworn I had made a change like that once before.

Also, I used "administer users" rather than "administer tac_lite", because I think that's more appropriate. Anyone care to disagree?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ollynevard’s picture

ollynevard commented

If a user has the "administer users" permission and not the "administer tac_lite" permission then the 'Taxonomy-based access' category is visible on the edit user page. However, if you click the category you get take to 'Page not found'.

Wouldn't the 'Taxonomy-based access' be more appropriate for this?

Alternatively would it be better to make both permissions mandatory and write a short access callback function to check them both (I believe user_access only accepts one access argument).