Line limit allows one line more than setting (counts line breaks instead of lines)

I'm not sure what you're asking for here. The line limit feature works by counting line breaks in the signature text, not by counting <br /> tags. The code is:

which you can see on line 299 of signature_forum.module, in the 6 -dev branch. Maybe it already works the way you expect? :)

There was a problem. I tested too quickly and we both are right in one part but still we both are "wrong" in one part.

To explain:

It has to do with the "carriage return" producing "soft return" \n or "hard return" \r. In FF browsers pressing enter key produces "soft return" \n but in IE pressing enter key produces "hard return" \r. In IE for the line counting feature to work

We must press Shift + enter to get "soft return". So in IE if user puts in more lines than we set with just enter key the above code will not count it like lines.

I just tested this in IE and it did count the returns.

There is a problem with what the feature says it does vs. what it actually does though: it's counting returns, instead of the number of lines. So, a signature with two lines of text would be counted as having one return (which is a bug and should be fixed). Maybe this is what's tripping you up?

We are getting there i think. Try this:

Set:

Line limit:

The maximum number of lines allowed in a signature

To let say number 3.

Then in any browser input:

line1
line2
line3

Works fine.

then try:

line1
line2
line3
line4

Works too.

line1
line2
line3
line4
line5

To many lines error.

So bottom line when i first tested this module i put in 4 lines of text in for test. I thought in IE line limit didn't work at all. I assumed it has to to something with hard return. If i would use 5 lines then instead of 4 for testing i probbably would not noticed this at all.

But now i see it works in both browsers the same just number of lines allowed +1 extra line. So this is i think the bottom line of this "feature request". Module allows 1 line of signature more then we set and that now i see confused me of thinking line count didn't work in IE.

Changing status and title. It's not a feature request, because the module should do what you are asking for, I just didn't think the logic through well-enough. :)

All's Well That Ends Well. ;)