I like this theme very much. It is the best RTL theme for Drupal by far, well commented, and very flexible. Thanks. However, I cannot turn off the 'Language Switcher'. I've followed the directions to the letter and flushed cache numerous times. I uncheck it and it does not disappear. Of course, I can just remove it from page.tpl, but, I don't like doing it that way. Any suggestions?

Cheers,

wim

Comments

tombigel’s picture

tombigel commented

Make sure that you are switching off the right one - If you are using "Tendu" switch off the one in "Tendu", if you are using "Tendu Default" switch off the one there.

Tell me if it is still doesn't work and I'll check it out.

battochir’s picture

battochir commented

I appreciate such a quick response. I am using "Tendu Deafault" and have made certain that I am switching the correct one off. Exactly where it says "These settings only exist for the Tendu Default Design theme and all the styles based on it." Right under it to be precise. I still can't get it to turn off. I would appreciate you verifying this to see if the problem is with me. I have done little to nothing with your theme as of yet. I plan to build on top of it, so if this on my side it would be even stranger! All suggestions appreciated. Thanks again.

cheers,

wim

tombigel’s picture

tombigel commented
Assigned: Unassigned » tombigel

Ha... You are correct, the same thing happens to me on http://tendu.tombigel.com.
Weird, I was sure I checked to see if it works, and it did.

There is a condition in template.php for this, I guess I'm doing something wrong there.

I'll look into it tonight.

Thanks
Tom B.

battochir’s picture

battochir commented

Thanks for validating this. I was going crazy over it. I appreciate your help.

cheers,
wim

tombigel’s picture

tombigel commented
Status: Active » Fixed

Man, it took me ages to find the stupid typo...

Well, thanks to you I found another typo and fixed it too.

1. in template.php of Tendu (the base theme), tendu_preprocess_page function, lines 104, 105:
Change "theme_get_settings" to "theme_get_setting" ("setting", in single form...)

2. In some places I misspelled "toggle_accessibility_links" as "toggle_accessibilty_links" (missed an "i" before "t" in "accessibility"):
In template.php and in theme-settings.php there are 5 occurrences of the misspelled word, just search and replace them all.

I committed the fixes already, so if you don't want to edit the code wait until the version will change to "beta 5" and download.
Note that "Doil" subtheme is back in, you can delete it for now.

Thanks again for the report.

battochir’s picture

battochir commented

Wow...you got that solved fast. I wish everyone on Drupal took reports as seriously as you do! I greatly appreciate you fixing the quirks you found in Tendu. I have great interest in this theme and plan to put it through the wringer and test it thouroughly, so I'll let you know if I find anything. I must say, you've written a very clean and well commented theme. For me, it's an uncomplicated Zen-like theme with RTL support...and that's awesome.

I'd like to ask if you plan on supporting mobile users with Tendu. I see you already have the accessibilty links in place. I pulled up your site on a couple mobile browsers--and it renders better than most. It's very usable. Do you plan on having a mobile specific css sheet? I ask because Drupal had two blaring weakenesses in the theme department. RTL themes--you fixed that very nicely. The other is mobile support. There are mobile themes, but they either don't work properly, are unsupported, or both. I think a RTL theme with mobile support would be awesome and would attract users who may not even need RTL support...just a flexible theme that supports mobile. Just my 2 cents.

Thanks again.

cheers,
wim

tombigel’s picture

tombigel commented

Tendu is important to me because it is first of all the base for most of my theming work, so any bug in it influences me directly.

About mobile support - I don't really have a great knowledge about mobile web, but I guess one day soon I'll stumble upon a project that demands it, and I'll have the reason to dig into it.

BTW - there is another typo in page.tpl I forgot to fix in beta 5 - I use $site-name instead of $site_name in some places, it should be changed.

If you read the text in the project page - This week we are conducting a design sprint for Drupal Israel (http://drupal.org.il) and Doil, which is a sub-theme of Tendu is in the center of this redesign. So you can expect more changes and fixes to Tendu in the upcoming weeks.

Tom B.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.