Closed (won't fix)
Project:
Wordpress Import
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2009 at 00:27 UTC
Updated:
30 Nov 2009 at 23:48 UTC
The code must be optimized a little. Just to make an example, the code could be changed from
$module_name = 'wordpress_import';
$dir = drupal_get_path('module', $module_name) .'/tests';
to
$dir = drupal_get_path('module', 'wordpress_import') .'/tests';
especially when $module_name is used just once on the function code.
Comments
Comment #1
avpadernoIt would also be preferable to use
if (is_null($r) {, rather thanif ($r === NULL) {.Comment #2
avpadernoAlso, if the string doesn't contain only spaces, and a zero, then
can be changed in
Comment #3
kmontyComment #4
avpadernoWhat I reported is still valid for the latest official release available.
Comment #5
lavamind commentedRelease 6.x-1.x will not get any further enhancements, only bug fixes.
Version 2.0 already includes many optimizations, but feel free to submit other enhancements for that version.