Upload module, file attachments, and iTunes podcasting problems

Hi,

I've been trying to get mp3's uploaded with the upload.module to work as a podcast in iTunes (with the 'Download method' in settings set to either 'private' or 'public'). I've identified several issues, and have some one-liner patches that solve these problems. First of all, iTunes is extremely flakey with the URL's it can handle, for example spaces in the file name and the '?' character cause it to choke and die. Really? Unbelievable, but true...

Patch number one takes care of the 'spaces in the file name issue' by URL encoding the filename.

If someone has the 'Download method' in settings set to 'private', this means that the URL will contain a '?', as in:
http://mysite.com/system/files?file=blah.mp3
This causes iTunes to die, so the second patch I have here makes all enclosures have full absolute URLs, regardless of the 'Download method'. Even if the download method is private, enclosures appear as full URLs.

When I was experimenting with this, I also noticed a strange bug in Firefox. When the download method is set to private, and the filename has a space in it, firefox (on both mac and PC), tries and saves the file using only the filename up to the first space. For example, if the filename is something like "01 song name.mp3", Firefox tries to save it as "01" (with no mp3 extension). This is solved by putting quotes around the filename in the Content-disposition headers. This is in patch 3.

I think these patches might solve bugs:
http://drupal.org/node/23759 spaces in filename
http://drupal.org/node/34807 firefox upload problem

Thanks!

-------------------
Colin Brumelle