Closed (fixed)
Project:
Session API
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2009 at 23:57 UTC
Updated:
22 Feb 2009 at 23:59 UTC
The implementation of hook_cron() has a few critical flaws. First, the code comment to "Run Session API hook first" implies that the session_api_session_api_cleanup() function should be run first, followed by other module cleanups. However, it simply uses array_unshift() to pop off the first item. If Flag module were to provide Session API support, it would actually become the first item in the list, since the modules are sorted alphabetically.
Secondly, the function "session_api_session_api_cleanup" is never actually run separately. So the cleanup of Session IDs never occurs.
| Comment | File | Size | Author |
|---|---|---|---|
| session_api_cron.patch | 844 bytes | quicksketch |
Comments
Comment #1
quicksketchOh silly me. I was thinking of "array_shift", not array_unshift(). The code is just fine. :P