Hi
I installed drupal 7 on a wamp5 system running windows xp pro sp2 version 2002
Ran simpletest. Selected only path.
113 passes, 0 fails, and 3 exceptions
All of the exceptions were like the one below.
rmdir(sites/default/files/simpletest37075): Permission denied
Warning file.inc 837 file_unmanaged_delete_recursive()

All three exceptions are caused by line 837 of file.inc it calls rmdir on a stream that is not closed.
The fix is to close the stream before trying to remove the directory. This only happens on a windows machine
I am submitting a patch rmdir_permission_wamp.patch. This my first patch so all suggestions will be appreciated.

CommentFileSizeAuthor
#2 rmdir_permission_wamp-381306-2.patch510 bytesplach
rmdir_permission_wamp.patch371 bytespuradata

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review
StatusFileSize
new rmdir_permission_wamp-381306-2.patch510 bytes

rerolled

c960657’s picture

c960657 commented
Status: Needs review » Reviewed & tested by the community

I didn't actually test this on Windows, but e.g this blog entry confirms your conclusion. And closing handles after use is generally a good thing.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.