author_pane error : "ip_address" does not exist

digemall - February 23, 2009 - 22:05
Project:User Stats
Version:6.x-1.0-beta2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

With version 1.0 beta2 (and beta1) I get this error in nodes:

user warning: Statistic "ip_address" does not exist. in /var/www/vhost/pinomillershow.org/home/html/sites/all/modules/user_stats/user_stats.module on line 167.
user warning: Statistic "ip_address" does not exist. in /var/www/vhost/pinomillershow.org/home/html/sites/all/modules/user_stats/user_stats.module on line 167.
user warning: Statistic "ip_address" does not exist. in /var/www/vhost/pinomillershow.org/home/html/sites/all/modules/user_stats/user_stats.module on line 167.
...

Only users without permission to see IP get this error.

Since there's one error line for each node comment, and "ip_address" is shown in the author_pane I've thougth that's an author_pane integration problem.

Furthermore, I've tried to change line 18 in "user_stats.author-pane.inc" setting $ip = ""
and everything went well (obviously excluding the ip ).

I hope this help. ;)

bye

#1

Liam McDermott - February 23, 2009 - 23:42

Good catch, it's a problem with the logic in user_stats_get_stats(). I've committed a fix, but can't do another release for bugs that aren't super-critical. :)

The -dev release will automatically update within 24 hours, then you can switch to it.

#2

Ingumsky - February 24, 2009 - 10:52

Thank you Liam!

Any patches to fix it? ;)

#3

Liam McDermott - February 24, 2009 - 18:15

Any patches to fix it? ;)

I didn't bother creating a patch as most users wouldn't know what to do with it. The -dev release has updated now, so I advise anyone with this issue to just use that. :)

#4

Liam McDermott - February 24, 2009 - 18:15
Status:active» fixed

#5

Ingumsky - February 24, 2009 - 19:21

Thanks mate!

#6

Ingumsky - February 25, 2009 - 08:14
Status:fixed» reviewed & tested by the community
AttachmentSize
ipaddress.patch 612 bytes

#7

Ingumsky - February 25, 2009 - 08:16

Liam McDermott
I've made the patch-file based on your work for those lazy fellas (like myself ;) who don't want to switch between "stable" and "unstable" module branches every time new minor bug was found -)

#8

Liam McDermott - February 25, 2009 - 18:59
Status:reviewed & tested by the community» fixed

Ingumsky: nice one, thanks. :)

#9

System Message - March 11, 2009 - 19:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#10

aharown07 - March 18, 2009 - 04:03

Thanks for patch. Working well for me

 
 

Drupal is a registered trademark of Dries Buytaert.