Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
if (json.posts[i].id >= first_id) {
220 while (Drupal.tribune.tribunes[tribune_id].pinnipede.find('li').length >= Drupal.settings.tribune.tribunes[tribune_id].history_size) {
221 if (Drupal.settings.tribune.tribunes[tribune_id].message_order == "top_to_bottom") {
222 var first = Drupal.tribune.tribunes[tribune_id].pinnipede.find('li:first'); // <!-- code in this condition is each time executed
223 } else {
224 var first = Drupal.tribune.tribunes[tribune_id].pinnipede.find('li:last');
225 }
226 first.each(function () { // <!-- it's not entering the function
227 var id_array = $(this).attr("id").split("-");
228 if (id_array.length == 2) {
229 delete Drupal.tribune.tribunes[tribune_id].postElements[id_array[1]];
230 }
231 $(this).remove();
232 });
233 }
So the real problem was that there was no validation on the edit form, so you could have a history_size of "" which doesn't mean much. It is fixed in CVS and in the next release
Comments
Comment #1
kenorb commentedLooped in while() in Javascript code:
Comment #2
kenorb commentedBefore the upgrade it was working fine.
If it can't be fixed, it's possible to backport tribune?
Comment #3
SeeSchloss commentedSo the real problem was that there was no validation on the edit form, so you could have a history_size of "" which doesn't mean much. It is fixed in CVS and in the next release
Comment #4
SeeSchloss commented