Machine-name fields are always in Latin characters, and should therefore always be LTR

trivial patch - works as described.

Patch rerolled against D6 HEAD.

Also included D7 version.

Needs more whitespace (one space at both before and after =>). Also, first get it committed to Drupal 7.

here

How to reproduce this problem? Please clarify the problem -- you're only describing the solution.

Can we write a D7 test for it?

The problem is that when your $language->direction is LANGAUGE_RTL, then the content type input field is also presented right-to-left. This does not make sense on its own, since the text must be in English, thus LTR.

I'm not sure how to write a test for it.

@Dries: There is not patch for this, it's UI thing, just changing the direction of content type machine name field, because it's always Latin characters i.e. always should be LTR.

Reproduce:
- Enable locale, add RTL language e.g. Arabic
- Go to content type edit page, click on edit machine name, the text field is RTL where it should be always LTR because it's only Latin characters allowed.

The above patches are ready for D7 and D6, the attached patch for D8.

All please for every RTL issue try to provide screenshots, before and after to see the difference.

Sorry, first title was a bit anglocentric. :)

Updated issue summary.

Added issue summary. The D8 patch needs to be rerolled/renamed so it goes through testbot, and I'm sure the D6 and D7 versions are stale by now. We should also check for whether there are other machine name fields that need this fix.

Testing D8 patch. Edit: This patch also applies cleanly to D7.

Maybe this should just be added to the type defaults in form_process_machine_name()? Edit: got it.

I count five core machine name fields that all should have this setting, so it seems reasonable to make it a default.

Please review and test the attached variant, which merges ltr directionality into the element defaults for all machine name fields. Specific forms may still override this.

I confirmed that it correctly makes the machine name field ltr under rtl languages for all five core forms that have this field type:

1. content types
2. vocabularies
3. menus
4. input formats
5. date types

Markup fail.

Proposed a more global solution.

Link to API function in patch.

Updated tasks.

More markup fail.

D6 doesn't have the machine_name field type, so here's the original D6 patch, rerolled for current codebase.

Tagging novice for review and manual testing. Follow the steps to reproduce from the summary both with and without the patch for all five of the forms mentioned in #19, and note the change. You can post (cropped) before and after screenshots to illustrate the change.

Since three people active on this issue speak a RTL language I believe it's clear that the change itself is desired for RTL UX, so we just need to review the latest patch from a technical perspective.

#19: all-machine-names-381994-19.patch queued for re-testing.

Rerolled for D8 /core. Also attached D7 patch. D6 is in #20.

Screenshots of the five areas mentioned #19. They are the only areas (in core) that have machinename. So manual testing them is a guarantee that it's working.

Thanks @good_man!

Oops, forgot this was my patch, so I can't RTBC it. :P

Anyone else can, though! The reroll above looks fine to me, and the screenshots demonstrate the solution works.

tim.plunkett suggested this simpler version.

And just confirming that the revised code works the same way:

Looks good to me.

Any reason we shouldn't add a test for this?

What would the test do? Ensure that machine names have the LTR direction set regardless of page direction? Not sure this is the complexity level we should test for. Its a "one line" change in the FAPI function for machine names...

It didn't occur to me to test it, but looking in locale's tests, I guess it wouldn't be too hard to add. I'll write one.

Looks like as complete test coverage as possible. :) Thanks!

Missed step in instructions.

Thanks for the test, looks great. Committed/pushed to 8.x. Moving back to 7.x for backport.

So I could not reroll this patch and had to recreate it manually, because of differences in the next test's docblock between D7 and D8. So, NR.

Ah, the form has also changed. I noticed this earlier but forgot. So the test will need to be adjusted as well.

Just changing the name of the select box to its D7 version.

Looks good to me.

Committed and pushed to 7.x. Thanks!

Moving down to 6.x.

Tagging for base language system.

Updated issue summary.