Bug under internet explorer when I want to apply a filter on content.
axman - February 24, 2009 - 09:56
| Project: | Weight |
| Version: | 6.x-1.0-beta3 |
| Component: | User interface |
| Category: | bug report |
| Priority: | critical |
| Assigned: | NancyDru |
| Status: | closed |
Description
I found a bug with internet explorer 7.0 :
When I want to apply a filter on my content under "content list", I can't !
When I choose a filter and click on "filter" button, my filter is not apply.
For information, filter work well under internet explorer without your module.
It work well with Firefox.
#1
Well, I can reproduce this. I will try to find out why it's happening.
#2
It turns out that something is blocking the "refine," "undo," and "reset" buttons from firing. I did discover a validation error and fixed that, but it is still not allowing those buttons to work.
#3
Hi NancyDru
Hope you are doing well.
I found the issue and resolved it.
The buttons "refine," "undo," and "reset" will not work as you have a form tag inside another form tag. IE does'nt like this. change lines in file weight.module
287 and 303 Remove the
<form>start tag on 287 and the close</form>tag on 303 this will resolve the filter issue.second is the problem with the ajax GET request generated when changing the weight from the listing page.
Onchange should generate the request as follows -
http://your.domain.com/drupalf6/?q=admin/node/weight/_weight_change/2/-19 instead of
http://your.domain.com/drupalf6/admin/node/weight/_weight_change/2/-19
notice the
?q=admin. so line 287 should be$selector_template = "\n"."<select style=\"margin: 0;\"onchange='httpRequest(\"GET\", \"" . base_path() .
"?q=admin/node/weight/_weight_change/\" + [NID] + \"/\" +
this.options[this.selectedIndex].value,true)' >";
so finally line 287 would look as above and line 303 would look like as below
$selector_template .= '</select>';Let me know if this is fine or if there are other ways of resolving it.
#4
#5
An issue is not "fixed" until something is committed to CVS.
Can you create this as a patch, please?
#6
sorry for that didn't know the rules
attached is a patch created using Winmerge let me know if it is ok.
#7
#8
This is still a complete module replacement. I need to see what was changed.
#9
Committed.
#10
Please check the differences on lines 287 and 303 for changes
#11
Check the -dev version for what I put in.
#12
Let me know where to check.
#13
Download the -dev version.
#14
Downloaded the -dev version and checked. changes have been made thank you. But tell me why is it still available in the Development snapshots section and not in the Releases section in the downloads page. Are new features being added to it?
#15
The -dev release is for people to test the changes before they go into an official release. I test on my system before committing it, but I can only do so much. Other people have really "creative" ways of using the module.
#16
Automatically closed -- issue fixed for 2 weeks with no activity.