Here are the release notes for rc1:

http://drupal.org/node/379728 [D6]
http://drupal.org/node/379730 [D5]

They should mention the "#305128, Use two dashes in templates" change. One user has already fallen for this.

I would have done this myself ...but I can't edit the release notes. Drupal complains of missing form fields. That's probably because of #227966: Use default values to #disabled form fields (which ought to be marked 'critical').

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

Thanks Mooffie, I updated the release pages with a little help from the Web Developer Toolbar (to enable the disabled fields so that they would save properly in Firefox).

quicksketch’s picture

quicksketch
he/him
commented

Thanks Mooffie, I updated the release pages with a little help from the Web Developer Toolbar (to enable the disabled fields so that they would save properly in Firefox).

mooffie’s picture

mooffie commented
Title: Release notes should mention the "two dashes" change. » Release notes should mention the ...
Status: Fixed » Active

Turns out there's yet another problem with templates:

The AJAX won't work when using old templates. That's because templates need a "flag-link-toggle" CSS class now, whereas in the past we used a "flag-link" class. In short, templates now need a "print $flag_classes".

That's complicated to explain, isn't it? Perhaps we should just instruct them "The CSS classes in the flag template have changed. Please create your templates anew." ?

youkho’s picture

youkho commented

i have a question (maybe a stupid one xD) why changing to print $flag_classes ?

mooffie’s picture

mooffie commented

@youkho: As I understand it, things work alright for you now; which means that you --advertently or inadvertently-- brought your "flag--recommends.tpl.php" file correctly up to date. Which means that you don't need to trouble yourself further ;-)

The purpose of this issue (#382242) it to provide some explanation so other admins who upgrade this module will know why strange things happen.

As for your question: if you look inside "flag.tpl.php", you'll see a print $flag_classes. It prints the CSS-names a certain tag in that template needs to have for the AJAX to work. If you happen not to have it in your "flag--recommentds.tpl.php", then you should consider this file defective and I guess the easiest thing to do is for you to start anew with the newly shipped "flag.tpl.php": copy it into "flag--recommends.tpl.php" and continue to do unto it what you did unto your previous "flag--recommends.tpl.php".

But, as I said before, if AJAX already works for your "recommeds" links, then you don't need to trouble yourself further.

quicksketch’s picture

quicksketch
he/him
commented

Thanks, I've included these instructions in the 1.0 release.

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

http://drupal.org/node/401652

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.