Here is my server specs:
- Windows Server 2003
- Microsoft-IIS/6.0
- PHP Version 5.2.8

I was receiving errors like this:
* The selected file C:\Inetpub\vhosts\site\httpdocs\files\temp\fil7AB.tmp could not be copied.
* The selected file C:\Inetpub\vhosts\site\httpdocs\files\temp\fil7AC.tmp could not be copied.
* The selected file C:\Inetpub\vhosts\site\httpdocs\files\temp\fil7AD.tmp could not be copied.

Basically the issue was that the file cache submodule of the ad module (ad/cache/file/ad_cache_file.module) was locking the cache files without releasing the lock which blocked drupal from overwriting the files.

I am not sure if I uploaded the patch correctly but the initial patch that was written for me by the great team over at lunarpages.com (shout out to Daniel!) worked perfectly.

Please review

CommentFileSizeAuthor
ad_cache.patch585 bytesinterestingaftermath

Comments

interestingaftermath’s picture

interestingaftermath commented

Can anyone review this?

jeremy’s picture

jeremy commented
Status: Needs review » Needs work

If we release the lock before writing the updated cache data, then someone else may grab the lock first and prevent us from being able to, resulting it data loss. Evidently Windows is treating locks differently than Unix based filesystems. I will not commit this patch, as it opens a race condition. I suspect it would be better to include a slightly modified version of Drupal's file_save_data() function in ad_cache_file.module, one that knows we already have the file pointer.

john franklin’s picture

john franklin commented
Status: Needs work » Closed (won't fix)

Closing out all bugs for 5.x and older versions of Drupal. If this is still an issue, please reopen and update with 6.x details.