This was first reported at http://www.ubercart.org/forum/bug_reports/8323/admin_created_order_tax_p....

Here is the proposed patch to fix the problem.

CommentFileSizeAuthor
#4 blank_product_tax-uc1.patch1.2 KBIsland Usurper
#1 blank_product_tax.patch1.86 KBIsland Usurper
blank_product_tax.patch1.19 KBIsland Usurper

Comments

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed
StatusFileSize
new blank_product_tax.patch1.86 KB

Had some data type confusion, so that's fixed now as well.

Committed new patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

plasticlax’s picture

plasticlax commented
Version: 6.x-2.x-dev » 5.x-1.7
Status: Closed (fixed) » Needs work

this is a major flaw and should be corrected in 1.x core, no?

Island Usurper’s picture

Island Usurper commented
Status: Needs work » Needs review
StatusFileSize
new blank_product_tax-uc1.patch1.2 KB

Oh, I guess. :)

tr’s picture

tr commented

@plasticlax: Have you tested the patch in #4 and does it work in UC 1.x ?

jimmb’s picture

jimmb commented

Hi TR,

We just applied that patch to Ubercart 5.x-1.9, and it's not working for me. On the test order, the tax is still disregarding the blank line items.

Jim

harkinj’s picture

harkinj commented
Version: 5.x-1.7 » 6.x-2.4
Priority: Normal » Critical

Hello Island Usurper,

Running Ubercart 6.x-2.4. I have items that are not shippable in my store that can't be taxed in Idaho. The tax is not being applied to the blank line items when you have in the admin/store/settings/taxes/1/edit for the tax rate of "Taxed Products" set to "Apply tax to shippable products only"

So I would like to figure out what I need to change to get the sales tax to apply to the blank line items when I have the "Apply tax to shippable products only" selected. I also have the check box selected for "TAXED PRODUCT TYPES" "Blank line" product.

I've tried all different ways to get the tax applied but the only way to get this to work is to check the bullet for "Apply tax to any product regardless of its shipability" But then it applies the tax to the non-shippable items.

John

Island Usurper’s picture

Island Usurper commented
Version: 6.x-2.4 » 5.x-1.9
Priority: Critical » Normal

This is actually a separate, though somewhat related, issue. Someone's already posted #899888: Shipping quotes on line items to deal with it.

tr’s picture

tr commented
Status: Needs review » Needs work

According to #6 the patch for UC 1.x doesn't work. Changing status ...

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Closed (won't fix)

It's too late to do anything with this now Drupal 5 is obsolete.