Add "- Open issues -" to status selection on advanced search

webchick - February 24, 2009 - 23:29
Project:Project issue tracking
Version:6.x-1.x-dev
Component:Views integration
Category:feature request
Priority:normal
Assigned:dww
Status:closed
Issue tags:drupal.org upgrade
Description

I love, love, love that the advanced search defaults to showing/searching *all* issues now, rather than just "active" ones. However, there are times when it's useful to search only active issues and currently doing this requires cmd+clicking like 10 items.

The main project listing pages have an "- Open issues-" selection that they default to. Could this same selection be added to advanced search?

#1

webchick - February 24, 2009 - 23:32

Since this is 'sorta' a regression from pre-D6 drupal.org, tagging appropriately.

#2

dww - February 25, 2009 - 07:07
Assigned to:Anonymous» dww
Status:active» needs review

Like so?

http://d6.drupal.org/project/issues/search

This actually simplifies the status filter handler code a bit, since I was going out of my way to hide this option in various cases. ;)

While I was at it, I made the following changes:

A) The underlying value is now capitalized as "Open" to be consistent with core view's "All" value.

B) The user-facing label is now <Open issues> to match core view's <Any> label.

C) The <Any> value is always present, even on multi-selects, to address the concern at #379362-10: Add "Advanced search" version of my projects page.

D) Cleaned up some of the internal code to make a little more sense.

Thoughts?

AttachmentSize
382888-2.open-and-any-status.patch 5.58 KB

#3

dww - February 25, 2009 - 08:25

Here's a patch that's less lethal for kittens. ;)

A) retained

B) Moved to a views issue: #383242: Change "<Any>" to "- Any -" in exposed filters

C) That was poorly conceived, and belongs at #379362: Add "Advanced search" version of my projects page if it should happen at all. No longer here.

D) retained

http://d6.drupal.org/project/issues/search

AttachmentSize
382888-3.open-status.patch 6.46 KB

#4

dww - February 25, 2009 - 10:57
Status:needs review» fixed

Committed and deployed:

http://drupal.org/project/issues/search

#5

webchick - February 25, 2009 - 16:07

Awesome! Thanks a lot! :D

#6

System Message - March 11, 2009 - 16:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.