Everything seems to be working so far (I love this module!)... though I am still testing ... plus as TR mentioned to me over @ ubercart "a weakness in Ubercart's architecture is there is no way to hook into this display. Hence my proposal for changing uc_currency_format() into a theme function which can be overridden" When we get that fixed there will be no need for the step in the readme which requires a hack of uc_core. Its not as urgent as I thought cause if you forget to make the change upon updating UC you will simply get a warning message and can fix it. Still would be nice to make the change to the currency_format function once and for all.

Anyways .. here is the file

@TR
Can we u or I add this to cvs as a 6.x branch? I do have a cvs account if you want me to do it.

CommentFileSizeAuthor
#29 multicurrency-6.x-1.0-beta5.zip16.56 KBMacronomicus
#5 multicurrency-6.x-1.0-beta4.zip16.91 KBMacronomicus
multicurrency-6.x-1.0-beta3.zip16.91 KBMacronomicus

Comments

ragavendra_bn’s picture

ragavendra_bn commented

Hi macrocosm,
Is the details provided in the README.txt for installation correct for installing on 6.x ............

ragavendra_bn’s picture

ragavendra_bn commented

Getting

warning: file_get_contents(sites/all/modules/ubercart/uc_multicurrency/uc_multicurrency.js?34047) [function.file-get-contents]: failed to open stream: No such file or directory in /home/fashion/public_html/drupal/includes/locale.inc on line 1685.

in Multi-Currency Settings --> Store currencies

tr’s picture

tr commented

"warning: file_get_contents(sites/all/modules/ubercart/uc_multicurrency/uc_multicurrency.js?34047)"

The port then neglected to change uc_add_js() to drupal_add_js().

Macronomicus’s picture

Macronomicus commented

Where did you get those errors? I haven't experienced that or the one above your post...
Are you using the Beta version of ubercart... and which beta are you using. I havnt upgraded to the latest just yet .... im using 6.x-2.0-beta4

@ragavendra_bn
Yes the instructions are ok for now ... just remember to install 6.x-2.0-beta4 .... I will have to try with 6.x-2.0-beta5 and see if that makes a diff.

Macronomicus’s picture

Macronomicus commented
StatusFileSize
new multicurrency-6.x-1.0-beta4.zip16.91 KB

Made change as per tr's suggestion
to change uc_add_js to drupal_add_js

ragavendra_bn’s picture

ragavendra_bn commented
Version: 6.x-1.x-dev »
Status: Closed (fixed) » Active

@macrocosm,
I got this message on ubercart-6.x-2.0-beta3.tar.gz
I am not sure of upgrading Ubercart. Let me know if possible.

@TR
I want to display the amount everywhere in my site in INR --> Indian Rupee
The amount to Paypal processor need to be sent in USD (after conversion from INR to USD)
Please help.........
http://www.FashionJewelry.co.in

jonloh’s picture

jonloh commented

It seems to work well for me, using the multicurrency-6.x-1.0-beta4 along with currency-6.x-1.x-dev and ubercart-6.x-2.0-beta5.

The only thing that the multicurrency module is unable to get the conversion rate automatically even though I left the field blank. I wonder is it because I have to use currency-6.x-1.0 instead of dev, or it is not working at the moment?

ragavendra_bn’s picture

ragavendra_bn commented

Hi macrocosm,
I used your multicurrency-6.x-1.0-beta4.zip on Ubercart-6.x-2.0-beta3 and no warnings came.

Now I have upgraded to Ubercart-6.x-2.0-beta4. One common issue I am seeing is when authenticated (United States) user selects different country (India), then the session doesn't change to India or its currency to INR. I am wondering why............

Macronomicus’s picture

Macronomicus commented
Version: » 5.x-1.1

I just want to clarify, I merely up-ported it so we all can start to bang away at a 6.x branch. I am not the mind behind the code here just trying to help out. I dont claim credit for this great module!

Do the prices change once they log out and back in?

How are you having them change the country? Mine is going to be based off of the users profile address. I have only tested this on 6.x-2.0-beta4, had a very hectic week and couldn't get back to testing meself.

Cheers ^_^

ragavendra_bn’s picture

ragavendra_bn commented

Ohh ok Marcosm. Great Work. Many waited for this D6 version. Glad to use your 6x module. It has helped.

Do the prices change once they log out and back in?
Yes it does.....

Changing country is done by enabling a block which comes along with this module. The block has a dropdown of the countries. Selecting other country and clicking on Go, doesn't update to that country or its currency........

Duplika’s picture

Duplika commented

TR, would you mind packaging the 6.x version please?

Macronomicus’s picture

Macronomicus commented

@ragavendra_bn
Ive not used the dropdown thingy yet. But im thinking it's got something to do with caching. Anonymous users get cached pages, I had similar problems with the cart block. Im not sure a good work around has been fashioned just yet. Other than keeping your site @ a default currency and forcing people to get free member account where they have access to more relevant page data like the cart block .. and apparently the country switcher block. Maybe you should just base the currency off of what they set in their profile? I guess thats not as userfriendly but why do they need to see other prices anyhow?

@Juanzo
I agree that might make things easier but perhaps tr has some refactoring in mind and hes waiting to see what comes of this post.

@tr
Are there any things in particular you want to see happen before we package a 6.x-dev version?

sammy-node’s picture

sammy-node commented

sub

asak’s picture

asak commented

+1 & subscribing!

xcorex’s picture

xcorex commented

+1 sub

xcorex’s picture

xcorex commented

White screen of death

Fatal error: Cannot redeclare uc_currency_format() (previously declared in /home/s/public_html/ely/sites/all/modules/ubercart/uc_store/uc_store.module:803) in /home/s/public_html/s/sites/all/modules/multicurrency/uc_multicurrency.module on line 1065

tr’s picture

tr commented

xcorex: That comes from not following the instructions.

This module has special installation requirements. Please read the included README.txt for details and installation instructions. Really. Don't even try to skip this step. There's important information in there, and if you don't follow all the special instructions it won't work.

Critical Tinkerer’s picture

Critical Tinkerer commented

+1

panji’s picture

panji commented

this module is deadly needed...

jonloh’s picture

jonloh commented

So there will be no way in displaying the converted currency for anonymous/not logged in users?

ragavendra_bn’s picture

ragavendra_bn commented

Hi macrocosm,
Thanks for your reply.
Regarding the drop down thingy, I tested it, so I thought I will report it. Anyway as you mentioned it doesn't matter much as of now for me as well.
The main purpose I want to achieve through Multicurrency is to enable the currency conversion at checkout to the payment processor(Paypal). I guess this feature is not part of Multicurrency, Any how I thought that slight modification to this module can may be help in achieving it.
My customers are from India, its currency is INR. Paypal doesn't support INR. Henceforth, the customers should be able to see the price/ amount in INR, where as the same amount need to be converted to USD and sent to Paypal.
As of now whatever currency is displayed is what is being sent to Paypal.

I guess there is one module in eCommerce which does what I need.
http://drupal.org/project/txn_currency

Macronomicus’s picture

Macronomicus commented

It will display in your default currency, for anonymous users. I haven't experimented with other setups, only my use case. ...and I am not using it in production just yet. From my testing though it appears to be working basically, it could certainly be developed further as it seems to be the only multi-currency module for 6.x ubercart.... at least that I am aware of. There are probably quite a few implementations that would benefit from uber-integrated multi-currency management.

Macronomicus’s picture

Macronomicus commented

@ragavendra_bn

If your willing to go the eCommerce route than I guess that could be an interesting module. Im pretty happy with ubercart though. IMO its a lot better.

tr’s picture

tr commented

ragavendra_bn: This module is not needed if you are just interested in displaying and using INR in your shop. Just set your store currency to INR. As far as PayPal goes, if you want to make the PayPal charge in a different currency than your store currency, you need to install the currency_api module and make a 1-line change in the PayPal module to do the currency conversion.

All others: This thread is titled: "I have up-ported this to Drupal 6.x". Please limit discussion to the topic of the D6 port provided by macrocosm. Open a new thread if you want to discuss other issues.

fralenuvol’s picture

fralenuvol commented

Hi Macrocosm,

I installed multicurrency-6.x-1.0-beta4 for drupal6.
I followed instructions and created also a profile field named "country_iso_code_2" according to README.txt.

But if I try to use the country selection block, nothing happens, neither if I am regularly logged in.

In comments #10 and #12 it is not clear to me if the fact that the country selection block does not work happens only to me or if it is a general issue.

Any thoughts how to fix it?

fralenuvol’s picture

fralenuvol commented

Hi again,
I answer my own question...

Reading the Drupal API documentation, I found the following fix for multicurrency-6.x-1.0-beta4:

In "uc_multicurrency.module" the function uc_multicurrency_country_select_form(&$form_state) at line 724:

before line 

  return $form;

add line

  $form['#submit'] = array('uc_multicurrency_country_select_form_submit_handler');

This way the country selection block works perfectly to me.

Macronomicus’s picture

Macronomicus commented

Sweet! Thanks for giving the block some attention.
I will add the fix after I test it.
Cheers!
^_^

ragavendra_bn’s picture

ragavendra_bn commented

Hi fralenuvol,

Your patch is working man. Cool :)

Tested macrocosm :)

Hi TR,
I have Currency API. In uc_paypal.module I tried replacing the uc_paypal_wps_currency to uc_currency_code but no luck :(
///////////

from:
'currency_code' => variable_get('uc_paypal_wps_currency', 'USD'),

to:
'currency_code' => variable_get('uc_currency_code', 'USD'),

///////////

Macronomicus’s picture

Macronomicus commented
StatusFileSize
new multicurrency-6.x-1.0-beta5.zip16.56 KB

Ok here is the next iteration including fralenuvol's tweak.

anea02’s picture

anea02 commented

I had the same issue as #25 with Beta 5

I added fralenuvol's fix to line 700 of Beta 5 (within the previously specified uc_multicurrency_country_select_form function) and it sprung to life (and allowed currency changes for logged on users). I THINK the fix has been put in the wrong place ( I found an identical line at 1039 and it looks out of place for that function)

Great module by the way!

Regards

Adam

tr’s picture

tr commented
Status: Active » Fixed

I have posted a D6 release on the project page for this module. You should use that release and report any problems with it in a separate issue. The release is tested and working for the most part, although there is one outstanding Drupal 6 core bug that affects the functionality of the disabled textfields.

I initially tried to work from the port posted above, but this seems to be only a deadwood port - there were lots of FormAPI changes that weren't accounted for in the above port so many things didn't work correctly. Which was pretty much what I expected, since this module is *mostly* forms and menus and those were the two things that had major changes in D6.

xcorex’s picture

xcorex commented

TR,

Did you know how to workaround the D6 core bug?

Thank you for the dev version.

tr’s picture

tr commented

The bug is http://drupal.org/node/227966. It's mostly an annoyance, where the values set in the disabled textfields get lost. It doesn't actually prevent anything from working. Work-around is just re-submit the form with the correct entries if they get lost.

Macronomicus’s picture

Macronomicus commented
Version: 5.x-1.1 » 6.x-1.x-dev

Thanks TR!

I really dont have any time to spare right now, I have way too much on my plate, and thanks to the great republican depression I had to fire most of my staff... and well ... hopefully I can begin to hire again once the republican stink gets plunged from the system... mehhh! Sorry .. rant over...

Having a real release keeps everyone on the same page, and able to contribute more constructively! I appreciate your taking that next step as it seems quite a few people want this baby for 6.x I will test your new code asap, still the original code above has worked for me, with no errors. lol funny... though I was using it quite simplistically. I did use deadwood but it really didn't do much, still had to hand hold the whole thing to get it to pass coder checks.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

massyboy’s picture

massyboy commented
Version: » 6.x-1.x-dev
Status: Active » Closed (fixed)

when refreshing the modules list (after following the readme.txt and putting the multicurrency module in the modules folder) I get
"Parse error: syntax error, unexpected '*' in C:\website\modules\multicurrency\uc_multicurrency.module on line 26"

a syntax error? huh? Am I the only one to get that error? a star sign as part of a comment end tab..
kinda frustrating when following trough the rabbit hole comming at a death end...