Make it possible to expose the filter for "Node: Has new content" [#384286]

It'd be nice to be able to expose the "Node: Has new content" filter, for example, to solve #309126: filter on new and updated issues. There are probably other use-cases, too. It seems like it could just be a trivial checkbox filter. I know checkboxes normally suck for exposed filters, since there's only two states: "yes" and "don't know", but in this case, that should be good enough. Any objections?

Comment	File	Size	Author
#1	384286-1.expose-has-new-content.patch	2.4 KB	dww
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dww

we/he/they

CreditAttribution: dww commented 27 February 2009 at 19:58

Assigned:	Unassigned	» dww
Status:	Active	» Needs review

File	Size
384286-1.expose-has-new-content.patch	2.4 KB

This works in my testing.

A) There's no UI to choose a default value since there's no way to tell when building the exposed filter if the checkbox is not selected vs. the default. So, it always defaults to off if you expose it, and you have to select the checkbox if you want to filter.

B) There are none of the usual options for the exposed filter like "force single", "optional", etc, since they make no sense. The only things the admin can configure are the label and the GET identifier.

C) The admin_summary() only tells you if the filter is exposed or not.

Any objections?

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 2 June 2009 at 19:10

Status:

Needs review

» Fixed

Committed! Thanks!

Comment #3

dww

we/he/they

CreditAttribution: dww commented 2 June 2009 at 19:20

Yay, thanks. ;)

Comment #4

16 June 2009 at 19:30

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #5

Steve Dondley CreditAttribution: Steve Dondley commented 20 June 2009 at 02:30

Status:

Closed (fixed)

» Needs work

Looks like this broke the regular, hidden filter. See http://drupal.org/node/496958

Comment #6

Steve Dondley CreditAttribution: Steve Dondley commented 20 June 2009 at 02:44

For those looking for a temporary fix, commenting out lines 41 - 44 of views/modules/node/views_handler_filter_history_user_timestamp.inc provides a band-aid solution. I'll step aside now and let the big boys figure this out.