Closed (fixed)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
26 Feb 2009 at 15:59 UTC
Updated:
3 Jan 2014 at 00:07 UTC
Jump to comment: Most recent, Most recent file
While Conditional Actions only covers a subset of the possible Workflow-ng configurations a site has, there is still a need to convert the Ubercart related ones to use the right triggers, conditions, and actions. Most of this code has already been written and committed into ca.module, but it's not actually implemented.
I don't think we should have a release candidate until this issue is fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | ca_conversion_4.patch | 15.66 KB | Island Usurper |
| #11 | ca_conversion_3.patch | 15.12 KB | Island Usurper |
| #10 | ca_conversion_2.patch | 16.07 KB | Island Usurper |
| #8 | ca_conversion_1.patch | 15.35 KB | rszrama |
| #3 | ca_conversion.patch | 7.25 KB | cha0s |
Comments
Comment #1
Island Usurper commentedTagged: update
Comment #2
Island Usurper commentedMenu rebuilding time. I've added a page at admin/store/ca/convert that lets you start a batch process to convert Workflow-ng configurations into Conditional Actions predicates. Post back with any conditions, actions, etc. that aren't converted properly because the corresponding CA integration hasn't happened yet.
Since Drupal upgrades are arduous, an easy way to test this patch is to copy a workflow_ng_cfgs table from a D5 database directly to a D6 database. It won't be affected by the conversion, or even used by anything else, so you can use it on a fresh D6 site if that's what you have.
Comment #3
cha0s commentedHere's an updated patch, just fixed some typos and display stuff. The menu item callback was broken too.
I sandboxed livetest.ubercart.org and updated it to Drupal 6, then ran the conversion. Everything seemed ok. I don't really have any other sites to test like this, so it'd be great if a couple of our power users could test with their specific configurations before we go ahead and give it the UberStamp of approval... hehe.
Comment #4
Island Usurper commentedThanks, cha0s.
I'd really like to see people who sell a lot of file downloads or role promotions to test this patch since it directly affects how those are granted to the customers. It's also important for those have really interesting tax and shipping rules that can be affected by this conversion. I just know that somebody's going to be left without a particular condition that they needed.
Comment #5
cha0s commentedSame here, that's what I was getting at...
So peoples, if you got a live site on 5 and are thinking about upgrading to 6, please test this!!!! (after you backup of course!)
Comment #6
rszrama commentedTagging.
Comment #7
rszrama commentedSo, I tested a full update and didn't run into any issues. I'm not entirely impressed w/ the configuration -> predicate conversion. It shows up as a local task in front of the default local task and it doesn't go away once you do the conversion. I also didn't see any noticeable affect. However, at this point, I'm fairly confident putting out a release candidate that can update from 1.x. Any more info?
Comment #8
rszrama commentedAlright, so I dug into this a little bit to rearrange the code and remove a lot of the scary "this might work" comments. While testing, though, I'm not even sure your batch process works. You're only doing a batch_set() and I'm not sure what causes the batch to start. Furthermore, I can't tell if the process is actually completing, because the final callback is never called according to this patch. It should be displaying a message and redirecting to the overview page. The idea here is once conversion completes it should hide the tab.
Comment #9
rszrama commentedAlso, fwiw in my test the condition on my KY sales tax configuration didn't convert over.
Comment #10
Island Usurper commentedIt turns out that batches need to be told which file to find the operations if they aren't in the .module itself, and they always need to be given an array of arguments, even if it's empty.
This patch looks like it works on the livetest's workflow_ng_cfgs table.
Comment #11
Island Usurper commentedThat update function doesn't belong here. It's from #399784: Predicate arguments are inconsistent. In addition, we should be careful to include changes made there in this patch, or vice versa, depending on which one gets committed first.
Comment #12
Island Usurper commentedJust committed #399784: Predicate arguments are inconsistent so I'll fix the arguments here, too.
Comment #13
Island Usurper commentedWell, enough's enough. We need this to get a release candidate going. If we find any conditions or actions that need to be converted, we can add them in as we find them.
I declare this issue fixed with this committed patch.