Performance issue
rsantiag - February 26, 2009 - 17:46
| Project: | ModuleInfo |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hi jabapyth,
I´m using moduleinfo for the last months, and I can see a reduction of the performance (in my development environment ). Today I solved my problems disabling moduleinfo.
Calling to the same page:
Execution time with moduleinfo: 24925.12 ms
Execution time without moduleinfo: 3820.76 ms
Moduleinfo slow down the site in more that 6 times!!!
I discover that moduleinfo is executed on every page call, not only for the module list page. And then, the more modules you have, the more time consuming.
Hope this can help you.
Regards,
#1
I made a quick patch for this issue, sorta a brute force way. Something is calling one of the sub functions thinking it is a hook, thats my guess as to why it gets executed on every page.
if ("admin/build/modules" == $_GET['q']){#2
#3
here's a better one.
#4
K I think I fixed the issue without the ugly.
#5
Hmmm... Why is this still not committed? This bug is lethal if you have hundreds of modules in your filesystem.
I found the same problem and developed the same patch independently, but looks like you have it there already. Please commit ASAP!
#6
I have not tested the patch, but I confirm extreme performance degradation which can even make difficult to disable the module. I have more than 100 modules, and no other choice as to disable the ModuleInfo module.
#7
Sorry about that. Committed!
#8
Automatically closed -- issue fixed for 2 weeks with no activity.
#9
@rsantiag --- thanks so much for figuring this out. All my sites were slow and I couldn't figure it out. I was suspicious of my hosting provider.