Better theming for Flash Code
danielb - February 27, 2009 - 01:25
| Project: | SlideShowPro |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Jump to:
Description
Currently the only way to theme the Flash code is by using string manipulation in theme_embed.
This patch provides another theme function where the actual Flash Code is assembled, allowing you to change the parameters and attributes of the outputted HTML code in a theme function override.
| Attachment | Size |
|---|---|
| flashtheme.patch | 3.32 KB |
#1
Great thing.
If you clean up the patch I'll commit :-) Are you not creating the patch with cvs diff?
We should also clean up theme_slideshowpro_feed() at some point. There is lots of application logic in the theme function. At least we should make it a template.
#2
What do you mean clean up the patch? I am using SVN. I don't really know the best way to set up this sort of patch, so I just made two directories, 'slideshowpro' and 'slideshowpro_patched' and then did a diff. I've tried applying the patch and it works without changing the names of anything.
Can you tell me the technique you would use to change 2 files with one patch, as in how would you set up your files to run the diff?