Make the GET page variable consistent with the real page number

This will need to go against HEAD, and then (possibly, but unlikely) to be back ported. Nice idea!

empty string minus one equals ????

also, the documnetation must be extended, something like
// Translate human readable page numbers to PHP offset logic

and vice verca

Both of the comments need a period on the end. Not sure the wording is quite right, but don't have suggestions.

This is an excellent idea.

A couple of suggestions for the comments if you don't want these ones:

// Translate human readable page numbers to PHP offset logic.
could be:
// Translate one based page numbers to be zero based for php usage.

// Translate PHP offset logic to human readable page numbers.
could be:
// Translate zero based page numbers to be one based for better human readability.

I think the comments in #5 are great.

grammar...

This is, sadly, too late for D7. We should do this at the start of D8.

subscribe.

Cross posts galore!

Argh!!!

Just want to see what the test bot will make of this patch, then will move to D8.

One last go...

for D7.

Victory! Patch is good for D7, but this issue should change in D8.

#18: drupal-385270.patch queued for re-testing.

Subscribe

#18: drupal-385270.patch queued for re-testing.

Well, that was a very old patch, so a quick, cosmetic re-roll.

Subscribing.

#26: drupal-385270-pager-consistent-26.patch queued for re-testing.

Re-roll.

#30: drupal-385270-pager-consistent-30.patch queued for re-testing.

Re-roll of patch from #30

#5: pager.patch queued for re-testing.

Just tried #33 patch on latest stable release of D7. Everything was applied successfully except for this...

Oops. That was not the D7 patch. Patch in #18 was applied successfully to D7. However, when used in conjunction with a paged View, using the pagination controls now jumps the page from nothing (0) to 2 to 4. Hmm...

patch #18 for D7, not working for me :(
I have the blocks views with a full navigation

work, there was a problem in the on side of the module, but the block views when you go to the link say "?page=4" becomes active link 5 in the pager

Views pagers don't use core's paging code I think, so you might have to patch views too,

Views is now part of Drupal 8. The patch should fix what Views does too, if that is not already done with the current patch.

For Comment # 37, in D7 you need to make change in views_plugin_pager_full.inc file .

in function set_current_page($number = NULL)
change

    for ($i = 0; $i <= $pager_id || $i < count($pager_page_array); $i++) {
      $pager_page_array[$i] = empty($page[$i]) ? 0 : $page[$i];
      $pager_page_array[$i]-- ; //add this line to decrease the page number in query
    }

This is now a duplicate of #1818040: Pager should start counting from 1, not 0 which has fresher comments.

All changes for Drupal 7 in one file.

I am trying to implement this in the contrib Pagerer module, see #3091945: Allow Pagerer to override the pager querystring part in URLs and count pages from 1, not 0. Reviews, tests, suggestions would be appreciated there.