This patch adds popup support to the Feed Aggregator module administration (admin/content/aggregator).

Also note that it only enables the support if the aggregator module is enabled (module_exists).

CommentFileSizeAuthor
#2 popupsaggregator.patch1.29 KBrobloach
#1 popupsaggregator.patch1.22 KBrobloach
popupsaggregator.patch1.14 KBrobloach

Comments

robloach’s picture

robloach
he/him
commented
StatusFileSize
new popupsaggregator.patch1.22 KB

This might be a bit safer because we're giving the tabs context rather then just the menu index.

robloach’s picture

robloach
he/him
commented
StatusFileSize
new popupsaggregator.patch1.29 KB

Sorry, that was ugly......

sirkitree’s picture

sirkitree commented

/me is not sure that you need the module_enable(). If the path isn't every loaded, then the js (of course) cannot. Is there another reason to use that?

robloach’s picture

robloach
he/him
commented

It saves a couple if statement checks every page load. Also allows us to split up the popup support into different module segments (cleaner).... You don't really want to check for the URL if you know it doesn't exist.