Only $form_state should be passed by reference.

CommentFileSizeAuthor
openid_provider_form_by_ref.patch812 bytesaron novak

Comments

anarcat’s picture

anarcat commented
Status: Needs review » Reviewed & tested by the community

The patch applies cleanly on HEAD and that function doesn't use $form, so I don't feel this requires functional testing. This is probably ready to go in the tree. Really minor nitpicking.

wundo’s picture

wundo commented
Issue tags: +dc2009 code sprint
wundo’s picture

wundo commented

Yeah, this patch works in D6-1 branch, but it's really minor.

walkah’s picture

walkah commented
Status: Reviewed & tested by the community » Fixed

committed, thanks :-)

Status: Fixed » Closed (fixed)
Issue tags: -dc2009 code sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +dc2009 code sprint

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.