Hello,

I get a strange display issue when an authenticated-user is watching another authenticated-user's profile page which haven't created a status yet, a lot of things on the page will get the wrong design - the one belonging to the Facebook-status div (.facebook_status_ajax_clickable_text).
this is hapenning only with users who can't edit the status on this page - won't happen for administrators or on your own page.
I hope I was clear enough, anyway you can see it for yourself, the site is in Hebrew but I hope you can manage :
go to : www.universeet.co.cc/user/login
login as :
user : guest
pass : guest
then go to a user's profile who has no status like : www.universeet.co.cc/user/25
you can compare that with a user that have a status : www.universeet.co.cc/user/3
somehow FireFox make it look even worse then IE7.

Is it somthing I did causing this ?
Thanks !

Comments

icecreamyou’s picture

icecreamyou commented
Title: A display issue on profile page » Unclosed <a> for non-editable statuses

What's happening is that there's an unclosed <a> tag in the status. There shouldn't be an opening <a> tag if the status isn't editable--the problem is near the line:

//Ugly hack to make the text look linked.

I just forgot to add a check to see if the form shows up. So in the line after that comment, this:

$fbs_name .= '<a class="facebook_status_ajax_clickable_text">';

should be changed to this:

if ($x) {
  $fbs_name .= '<a class="facebook_status_ajax_clickable_text">';
}

I will make that change, test, and commit as soon as I can, but feel free to change your local copy in the mean time.

icecreamyou’s picture

icecreamyou commented
Assigned: Unassigned » icecreamyou
Status: Active » Fixed

Committed to both branches in dev.

tsi’s picture

tsi commented

Thanks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.