Don't cache pages when there are PHP/MySQL errors

I'm currently in Los Angeles (not home) until the 20th, but this will be a top priority once I get back. Fix is easy, if the above code you gave is correct.

Before

/**
 * Implementation of hook_init(). Performs page setup tasks if page not cached.
 */
function boost_init() {
  // Stop right here unless we're being called for an ordinary page request
  if (strpos($_SERVER['SCRIPT_FILENAME'], 'index.php') === FALSE || variable_get('site_offline', 0))
    return;

After

/**
 * Implementation of hook_init(). Performs page setup tasks if page not cached.
 */
function boost_init() {
  // Stop right here unless we're being called for an ordinary, error free page request
  if (strpos($_SERVER['SCRIPT_FILENAME'], 'index.php') === FALSE || variable_get('site_offline', 0) || count(error_get_last()))
    return;

While here we should also check for drupal messages; those shouldn't be cached.
http://api.drupal.org/api/function/drupal_set_message
http://api.drupal.org/api/function/page_get_cache

Here's a list of errors
http://www.php.net/errorfunc.constants
http://www.php.net/error_get_last

If you could write the logic so it only halts on critical & writing to the output, errors that would be quite helpful.

I think these are the 4 errors in which boost should ignore and cache the page

if ($error = error_get_last()){
  switch($error['type']){
    case E_NOTICE: //Ignore run-time notices
    case E_USER_NOTICE: //Ignore user-generated notice message
    case E_DEPRECATED: //Ignore run-time notices
    case E_USER_DEPRECATED: //Ignore user-generated notice message
      break;
    default: //Do not cache page on all other errors
      return;
    }
  }

So this is what the new code block would look like

/**
* Implementation of hook_init(). Performs page setup tasks if page not cached.
*/
function boost_init() {
  // Stop right here unless we're being called for an ordinary, error free page request
  if (strpos($_SERVER['SCRIPT_FILENAME'], 'index.php') === FALSE || variable_get('site_offline', 0) || $user->uid || $_SERVER['REQUEST_METHOD'] != 'GET' || count(drupal_get_messages(NULL, FALSE)) || $_SERVER['SERVER_SOFTWARE'] === 'PHP CLI')
    return;
if ($error = error_get_last()){
  switch($error['type']){
    case E_NOTICE: //Ignore run-time notices
    case E_USER_NOTICE: //Ignore user-generated notice message
    case E_DEPRECATED: //Ignore run-time notices
    case E_USER_DEPRECATED: //Ignore user-generated notice message
      break;
    default: //Do not cache page on all other errors
      return;
    }
  }

Good point, I'll add the error checks into the _boost_ob_handler() function, so count(drupal_get_messages(NULL, FALSE)) and error_get_last() would go in there.

Decided to clean up boost_init while we are here. This really hasn't been tested since I have to run; will test later.

Here's how it looks

/**
 * Implementation of hook_init(). Performs page setup tasks if page not cached.
 */
function boost_init() {
  // Make the proper filename for our query
  $fname = '';
  foreach ($_GET as $key => $val) {
    if ($key != 'q') {
      $fname .= (empty($fname) ? '' : '&') . $key . '=' . $val;
    }
  }
  //set variables
  $GLOBALS['_boost_query'] = (empty($fname) ? '' : '_' . $fname);
  $GLOBALS['_boost_path'] = (empty($_REQUEST['q'])) ? 'index' : $_REQUEST['q'];
  global $user;
  
  // Make sure the page is/should be cached according to our current configuration
  if (   strpos($_SERVER['SCRIPT_FILENAME'], 'index.php') === FALSE 
      || variable_get('site_offline', 0) 
      || $_SERVER['REQUEST_METHOD'] != 'GET' 
      || $_SERVER['SERVER_SOFTWARE'] === 'PHP CLI'
      || variable_get('cache', CACHE_DISABLED)
      || !BOOST_ENABLED
      || isset($_GET['nocache'])
      || !boost_is_cacheable($GLOBALS['_boost_path'])
      ) {
    return;
  }
    
  // For authenticated users, set a special cookie to prevent them
  // inadvertently getting served pages from the static page cache.
  if (!empty($user->uid)) {
    boost_set_cookie($user);
  }
  // We only generate cached pages for anonymous visitors.
  else {
    ob_start('_boost_ob_handler');
  }
}

Tested above code and it works; meaning the hook_init rewrite is good. Inside the patch is the do not cache errors code as well; this is a little bit harder to test so any error testing is greatly appreciated.

committed

Adding code to boost block so admin knows the page can not be cached due to php/drupal errors/messages. Also used hook_help as a hack to get the correct values from drupal_get_messages().

Changing above patch do to this issue #480266: PHP < 5.2.0 - No files created since update to 6.x-1.0-beta1 due to missing error_get_last(). Also did some code cleanup of the patch.

incorporating #480266: PHP < 5.2.0 - No files created since update to 6.x-1.0-beta1 due to missing error_get_last() into this patch since it's related. Formatted the block better as well.

Added a setting to control if boost will cache on errors.

committed

if i uncheck the new checkbox and save the settings, the checkbox is checked again

I can not confirm this, it works for me. Try unchecking it one more time; it makes no since. In the mean time I've done more cosmetic changes to boost's watchdog errors, and added more as well. Also changed the default to false, because php throws errors too easily.

This patch requires the one above to be applied first.

committed above changes so next dev will have the default set to false

Ok it was my fault, somehow the previous patch messed up my module file. I re applied Patch 3 and then Patch 4, now everything is working as expected.

Thanks for all your support and this great module.