Hi,

first of all thx for "Tweet".

I'm using "Tweet" on a website which tries to be as xhtml 1.0 strict as possible. "Tweet" uses the target="_blank" attribute in it's links to twitter, which is deprecated.
To solve this little "problem" and to make "Tweet" xhtml 1.0 strict, it's only necessary to change line 137 of tweet.module (6.x-1.5) from
$attributes = array('target' => '_blank', 'class' => 'tweet', 'rel' => 'nofollow');
to
$attributes = array('class' => 'tweet', 'rel' => 'nofollow');.

Another (more elaborate) way to solve this, would be to open "Tweet"-Links in external windows by using JavaScript.

Cheers,
Jan

--
www.bitbunnys.de

Comments

icecreamyou’s picture

Assigned: Unassigned » icecreamyou
Status: Patch (to be ported) » Active

I was actually thinking about that yesterday. Instead of your suggestion I think what I'm going to do is add an option in the settings to choose which method to use in case some sites prefer not to rely on JavaScript. I'm going to be really busy for the next two weeks but I'll do what I can to get this into a release as soon as possible.

Joe Malik’s picture

Nice,

thx a lot!

icecreamyou’s picture

Status: Active » Fixed

Found some time - committed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.