Closed (fixed)
Project:
Tweet
Version:
6.x-1.5
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
27 Feb 2009 at 19:47 UTC
Updated:
13 Mar 2009 at 23:10 UTC
Hi,
first of all thx for "Tweet".
I'm using "Tweet" on a website which tries to be as xhtml 1.0 strict as possible. "Tweet" uses the target="_blank" attribute in it's links to twitter, which is deprecated.
To solve this little "problem" and to make "Tweet" xhtml 1.0 strict, it's only necessary to change line 137 of tweet.module (6.x-1.5) from
$attributes = array('target' => '_blank', 'class' => 'tweet', 'rel' => 'nofollow');
to
$attributes = array('class' => 'tweet', 'rel' => 'nofollow');.
Another (more elaborate) way to solve this, would be to open "Tweet"-Links in external windows by using JavaScript.
Cheers,
Jan
Comments
Comment #1
icecreamyou commentedI was actually thinking about that yesterday. Instead of your suggestion I think what I'm going to do is add an option in the settings to choose which method to use in case some sites prefer not to rely on JavaScript. I'm going to be really busy for the next two weeks but I'll do what I can to get this into a release as soon as possible.
Comment #2
Joe Malik commentedNice,
thx a lot!
Comment #3
icecreamyou commentedFound some time - committed to dev.