The rule that says "The first two watchdog() parameters should be literal strings." shows the line before the watchdog() call.

Comments

stella’s picture

Status: Active » Postponed (maintainer needs more info)

I don't think this is still an issue, at least not using the latest dev version. Can you confirm?

Cheers,
Stella

Island Usurper’s picture

Status: Postponed (maintainer needs more info) » Active

Yes, the problem is still there as of the 2009-Mar-06 dev version.

If you want a live example, the uc_credit module in Ubercart has a bad watchdog() call on line 884. However, the "Interface text translatability" review flags line 883.

           $message = t('Credit card encryption key file creation failed. Check your filepath settings and directory permissions.');
/* 883 */  drupal_set_message($message, 'error');
/* 884 */  watchdog('uc_credit', $message, WATCHDOG_ERROR);
klausi’s picture

Issue summary: View changes
Status: Active » Closed (won't fix)

Coder for Drupal 6 is now frozen and only security fixes will be applied. Feel free to update this issue and reopen against 7.x-2.x or 8.x-2.x.