'Use a common default value for all nodes..' not being applied automatically.

muhleder - February 28, 2009 - 02:28
Project:Viewfield
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi,

as I understand the module, when 'Use a common default value for all nodes..' is checked, the viewfield should automatically display on the node, ie the node shouldn't have to be saved in order to get the viewfield to display. This option is referred to as the 'super default' in the code(?)

This isn't currently happening, but this patch seems to get it working. It just adds a check to see if the super_default is enabled, and if so loads the default settings for the viewfield (using the existing codeblock that sets the defaults where the viewfield has been saved as ).

I've also clarified the comment in the code a little bit.

patched against the 20 feb 6.x-1.x-dev release.

mark

AttachmentSize
viewfield-superdefaults.patch693 bytes

#1

Darren Oh - March 6, 2009 - 20:35
Status:needs review» fixed

Fixed in CVS commit 179786.

#2

nguyenquocviet - March 13, 2009 - 06:17

Hi Darren Oh,

I am using the latest CVS version of this module with ver 1.11 of viewfield.module file. Meaning that this bug should be fixed. But I still got this error. In Default value settings, the argument value is not saved and there is no result at all on the nodes that use viewfiled.

Could you please check this?

Thanks
Nguyen Quoc Viet

#3

rhache - March 20, 2009 - 21:11

I have the same issue.

Whatever defaults I specify in viewfield does not stick. If I submit and configure the field again, my defaults are gone.

I'm using the latest DEV version from March 9, 2009.

Thanks,
Rene

#4

muhleder - March 21, 2009 - 23:36

Hi guys,

I know this issue is marked as a duplicate of

http://drupal.org/node/376433

but I think they're separate.

I had to use the hack I specified in that thread to get settings to hold.

The patch above is not about getting settings to hold, it just makes the viewfield display without having to go through and save each node.

Mark

#5

Darren Oh - March 23, 2009 - 13:38
Status:fixed» closed

Re-activated issue 376433. Closing this issue.

#6

Darren Oh - April 7, 2009 - 18:46

This patch prevents nodes from overriding default values. Reverted in CVS commit 194046. I believe other modifications fixed the problem.

#7

muhleder - July 21, 2009 - 10:51

Sorry to reopen this but I'm seeing this behavior again with the lastest dev version from CVS.

On a practical level it generally only happens when you're first setting up your content types, but it can waste quite a bit of time until you realise you have to go and resave every node after adding a viewfield.

The code looks to be refactored since the last patch so the last patch is irrelevant to the current code.

Thanks for a great module anyway.

Mark

#8

muhleder - July 21, 2009 - 10:53
Status:closed» active

And actually reopening the issue.

#9

webel - December 21, 2009 - 10:11

This is still a (serious) problem: related issue: #573160: Neither [nid] nor %nid passed correctly as arguments.

#10

webel - December 21, 2009 - 10:26
Status:active» closed

Fixed using: 6.x-1.x-dev 2009-Dec-03.

Thanks for this successful update.

Please do in future take the time to indicate issues addressed by new releases.

Closing.

 
 

Drupal is a registered trademark of Dries Buytaert.