Hi,

as I understand the module, when 'Use a common default value for all nodes..' is checked, the viewfield should automatically display on the node, ie the node shouldn't have to be saved in order to get the viewfield to display. This option is referred to as the 'super default' in the code(?)

This isn't currently happening, but this patch seems to get it working. It just adds a check to see if the super_default is enabled, and if so loads the default settings for the viewfield (using the existing codeblock that sets the defaults where the viewfield has been saved as ).

I've also clarified the comment in the code a little bit.

patched against the 20 feb 6.x-1.x-dev release.

mark

CommentFileSizeAuthor
viewfield-superdefaults.patch693 bytesmuhleder

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Fixed

Fixed in CVS commit 179786.

nguyenquocviet’s picture

nguyenquocviet commented

Hi Darren Oh,

I am using the latest CVS version of this module with ver 1.11 of viewfield.module file. Meaning that this bug should be fixed. But I still got this error. In Default value settings, the argument value is not saved and there is no result at all on the nodes that use viewfiled.

Could you please check this?

Thanks
Nguyen Quoc Viet

rhache’s picture

rhache commented

I have the same issue.

Whatever defaults I specify in viewfield does not stick. If I submit and configure the field again, my defaults are gone.

I'm using the latest DEV version from March 9, 2009.

Thanks,
Rene

muhleder’s picture

muhleder commented

Hi guys,

I know this issue is marked as a duplicate of

http://drupal.org/node/376433

but I think they're separate.

I had to use the hack I specified in that thread to get settings to hold.

The patch above is not about getting settings to hold, it just makes the viewfield display without having to go through and save each node.

Mark

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Fixed » Closed (fixed)

Re-activated issue 376433. Closing this issue.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

This patch prevents nodes from overriding default values. Reverted in CVS commit 194046. I believe other modifications fixed the problem.

muhleder’s picture

muhleder commented

Sorry to reopen this but I'm seeing this behavior again with the lastest dev version from CVS.

On a practical level it generally only happens when you're first setting up your content types, but it can waste quite a bit of time until you realise you have to go and resave every node after adding a viewfield.

The code looks to be refactored since the last patch so the last patch is irrelevant to the current code.

Thanks for a great module anyway.

Mark

muhleder’s picture

muhleder commented
Status: Closed (fixed) » Active

And actually reopening the issue.

webel’s picture

webel commented

This is still a (serious) problem: related issue: #573160: Neither [nid] nor %nid passed correctly as arguments.

webel’s picture

webel commented
Status: Active » Closed (fixed)

Fixed using: 6.x-1.x-dev 2009-Dec-03.

Thanks for this successful update.

Please do in future take the time to indicate issues addressed by new releases.

Closing.

ericinwisconsin’s picture

ericinwisconsin commented
Status: Closed (fixed) » Active

Sorry to reopen, but I'm using the dev version, but the issue persists.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Postponed (maintainer needs more info)

What problem remained?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Postponed (maintainer needs more info) » Closed (fixed)