Can't ignore unsupported projects
sgabe - February 28, 2009 - 11:21
| Project: | Update Status |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | dww |
| Status: | closed |
Description
I am using Drupal 5.x with Countdown module, wich has no more 5.x supported release. So I changed the Update Status settings to never notify me about this module, but it keeps me up to date continuously. It is very annoying...

#1
Same problem here. Modules marked "Never" still get flagged on every check.
#2
Same problem for me. I have it set to never but it checks every time.
#3
This is actually by design. update_status doesn't let you ignore projects that are insecure or unsupported. It's not a bug, it was a conscious design choice. However, I'm willing to reconsider this design choice...
#4
The problem is that some module maintainers, because they do not wish to support the module any longer or to support earlier versions, just summarily remove them from Drupal. While that's their privilege, it's hardly the same as a module that is insecure. The module might well be quite safe and stable but simply be orphaned as a result of the maintainer's decision. The result in my particular case is that I get daily reminders that a particular module is unsupported when all that happened was that the maintainer decided now that he has a D6 version, he no longer cared about the D5 version or it's users. (Ironically, he didn't even do the D6 port himself!)
I should be able to make this decision myself and disable the alert when there is no safety issue and I am willing to maintain it for my own use.
#5
Hrm. I just tried testing this on a local D5 test site. I have a few modules with a 5.x-1.* branch that's now marked unsupported by the maintainer. When I set those modules to notify "never" in the settings page, it all works as expected. The available updates report looks completely as expected (see attached). It even lets you ignore a security release. ;) Furthermore, the notification emails honor these settings -- so, once I ignore the unsupported and insecure releases, clear the datestamp when update_status last checked for updates, and run cron, I either get an email saying "you're missing some updates" (for the other modules that are out of date), or no email at all (if I set the notification threshold to "Only security updates").
Can you try updating to the latest code at the end of the DRUPAL-5--2 branch and let me know if you're still experiencing any problems?
As far as I can see, this all works as y'all want it to, not how I thought it did. ;)
#6
I installed the latest -dev version and refreshed the update listing several times. Reset the settings page. Repeat. No go.
#7
I can't do anything with this if I can't reproduce it. Please provide detailed steps to reproduce, the exact versions of all of your contrib modules, a complete screenshot of your available updates report, etc.
#8
A concrete example is the Countdown module, which doesn't have a supported 5.x version anymore. I set this one to never notify, but it keeps coming.
#9
Cool, I can reproduce that, and I now see what the problem is. There are a few different ways that things can be marked "unsupported" in the release history XML, and one of them triggers this bug (where there are no supported branches at all for a given version of core). So, the case I was testing (and which worked) is where you have both supported and unsupported branches for D5 -- in that case, you can ignore the unsupported branches. However, if the entire project is considered unsupported for D5, that bails out before it considers the ignore settings.
This same bug probably exists in core, although update advanced can probably work around it if #445748: Add hook_update_projects_alter() gets in (maybe it can already work around it, in fact). This requires further investigation...
#10
Try this on for size. Looks like in D6 this isn't a problem since hook_update_status_alter() is invoked at the very end of update_calculate_project_data(), which is effectively what this patch here does in terms of the ignore settings in D5.
#11
Thanks for the patch, but users who can't access the drupal-contrib repository can't apply this, because it doesn't fit for the anonymous drupal cvs repository.
#12
@sgabe: Huh? It's a patch against the latest code in DRUPAL-5--2. You can either check out that code anonymously from the drupal cvs repository (see the CVS instructions tab on the update_status project page -- be sure to select the DRUPAL-5--2 branch.), or by downloading the update_status 5.x-2.x-dev release.
Furthermore, I'm planning to commit this and release 5.x-2.4 in the short term future (see #478928: Release update_status 5.x-2.4). I'm just asking for people (namely those of you in this issue) to review and test the changes. Anyone on Earth, regardless of their CVS access, can test this patch. See http://drupal.org/patch/apply for more if you need help with that.
Cheers,
-Derek
#13
I couldn't apply it on the cvs repo, but it successfully applied on the downloaded update_status 5.x-2.x-dev release, now it seems to work just fine, thanks!
#14
Works now! Thank, thank you. The patch fixed the problem.
#15
Committed to DRUPAL-5--2: http://drupal.org/cvs?commit=220934 This will be out with 5.x-2.4.
#16
Automatically closed -- issue fixed for 2 weeks with no activity.