The patch improves the legibility of the code.

CommentFileSizeAuthor
#6 term-display-code-improvement-d5.patch2.32 KBrstamm
#2 term-display-code-improvement2.patch2.77 KBrstamm
term-display-code-improvement.patch2.28 KBrstamm

Comments

joachim’s picture

joachim commented
Status: Needs review » Needs work

Good catch on the foreach spacing!
But code style for 6.x is one space each side of a . operator.
Any particular reason you're moving hook_theme lower down? I can't tell just from looking at the patch. You putting it immediately above the theme functions?

rstamm’s picture

rstamm commented
StatusFileSize
new term-display-code-improvement2.patch2.77 KB

Fixed code style and moved hook_theme and theme functions to the top.

rstamm’s picture

rstamm commented
Status: Needs work » Needs review
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks, please go ahead and apply.

rstamm’s picture

rstamm commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

rstamm’s picture

rstamm commented
Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Fixed » Needs review
StatusFileSize
new term-display-code-improvement-d5.patch2.32 KB

Moved theme functions to the top and removed whitespaces.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thanks.

It makes sense to keep D5 parallel to HEAD for ease in backporting.

rstamm’s picture

rstamm commented
Status: Reviewed & tested by the community » Fixed

Committed to D5.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.