Improve the legibility of the code

Ralf - February 28, 2009 - 14:54
Project:Term Display
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

The patch improves the legibility of the code.

AttachmentSize
term-display-code-improvement.patch2.28 KB

#1

joachim - March 12, 2009 - 22:09
Status:needs review» needs work

Good catch on the foreach spacing!
But code style for 6.x is one space each side of a . operator.
Any particular reason you're moving hook_theme lower down? I can't tell just from looking at the patch. You putting it immediately above the theme functions?

#2

Ralf - March 15, 2009 - 09:08

Fixed code style and moved hook_theme and theme functions to the top.

AttachmentSize
term-display-code-improvement2.patch 2.77 KB

#3

Ralf - March 15, 2009 - 09:09
Status:needs work» needs review

#4

nedjo - March 15, 2009 - 15:41
Status:needs review» reviewed & tested by the community

Thanks, please go ahead and apply.

#5

Ralf - March 15, 2009 - 17:53
Status:reviewed & tested by the community» fixed

Committed to HEAD.

#6

Ralf - March 15, 2009 - 18:02
Version:6.x-1.x-dev» 5.x-1.x-dev
Status:fixed» needs review

Moved theme functions to the top and removed whitespaces.

AttachmentSize
term-display-code-improvement-d5.patch 2.32 KB

#7

nedjo - March 15, 2009 - 18:04
Status:needs review» reviewed & tested by the community

Thanks.

It makes sense to keep D5 parallel to HEAD for ease in backporting.

#8

Ralf - March 15, 2009 - 18:27
Status:reviewed & tested by the community» fixed

Committed to D5.

#9

System Message - March 29, 2009 - 18:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.