Download & Extend
Term Display » Issues

Improve the legibility of the code

Posted by Ralf on February 28, 2009 at 2:54pm
Project:Term Display
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The patch improves the legibility of the code.

AttachmentSize
term-display-code-improvement.patch2.28 KB
Login or register to post comments

Comments

#1

Posted by joachim on March 12, 2009 at 10:09pm
Status:needs review» needs work

Good catch on the foreach spacing!
But code style for 6.x is one space each side of a . operator.
Any particular reason you're moving hook_theme lower down? I can't tell just from looking at the patch. You putting it immediately above the theme functions?

#2

Posted by Ralf on March 15, 2009 at 9:08am

Fixed code style and moved hook_theme and theme functions to the top.

AttachmentSize
term-display-code-improvement2.patch 2.77 KB

#3

Posted by Ralf on March 15, 2009 at 9:09am
Status:needs work» needs review

#4

Posted by nedjo on March 15, 2009 at 3:41pm
Status:needs review» reviewed & tested by the community

Thanks, please go ahead and apply.

#5

Posted by Ralf on March 15, 2009 at 5:53pm
Status:reviewed & tested by the community» fixed

Committed to HEAD.

#6

Posted by Ralf on March 15, 2009 at 6:02pm
Version:6.x-1.x-dev» 5.x-1.x-dev
Status:fixed» needs review

Moved theme functions to the top and removed whitespaces.

AttachmentSize
term-display-code-improvement-d5.patch 2.32 KB

#7

Posted by nedjo on March 15, 2009 at 6:04pm
Status:needs review» reviewed & tested by the community

Thanks.

It makes sense to keep D5 parallel to HEAD for ease in backporting.

#8

Posted by Ralf on March 15, 2009 at 6:27pm
Status:reviewed & tested by the community» fixed

Committed to D5.

#9

Posted by System Message on March 29, 2009 at 6:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.