Getting Buddylist ready for 4.7

Great news, thanks for your work.

Hmm.. this [most recent, 11/28] patch seems to reduce the number of errors that occur, but there are still two occurences of form_item which breaks looking at other users' profiles.

Oh, no, wait, I forgot to apply the first patch. My bad!

Sorry for posting so little content at such high frequency, but I have an update..

SO, I've tried to apply all these patches to buddylist.module with lackluster results. Adding buddies is broken, as well as the administration screen. form_select is still in the module numerous times and is apparently an undefined function in 4.7.

Maybe, if anyone has this working under 4.7 they could do a diff of their .module versus the one in cvs right now? Because if it's possible to patch this file four times and get it working in 4.7, it's certainly beyond me.. :(

The diff arguments were backwards creating the patch. When patched, the newly inserted lines are removed and the original ones re-instated. Maybe my patch program has an argument to reverse the roles. Mark (?) - could we get a new diff?

With Unix patch you can use '-R' to apply the backwards diffs. I've done this and created a patch that should be able to be used directly. This contains the 20051128 patch, which looks like it is a rollup of all the others.

Now that I've applied the previous patch and actually tried it, found several things that weren't quite right. Seems it only works for the admin and not mortal users. I've changed it so that folks with suitable access can actually add and remove buddies without getting 'page not found' errors and double escaped forwarding URL's and lots of other lovely surprises. Check your access rights because there appears to be two conflicting methods of specifying 'can add/remove buddies'. Rather than wholesale slaughter of the module to use one or the other and get it right, I just used both settings.

This will probably cause a permission related bug somewhere, but at this point I'm only trying to get it working with basic functionality on 4.7. This module needs some (a lot) more work. Also corrected some text which wanted you to confirm adding a buddy - except that the text appears when you're deleting a buddy. This is not an incremental patch. It is a complete patch to cvs HEAD of 12/25/2005.

Looks like 4.7b3 user API changed somehow and my previous patch broke. So here it is again.

This time I've also resolved the conflicting admin rights, and ensured that the user page UI can be translated. Once again, this is a complete patch against the current CVS version of the buddylist module for Drupal 4.7 beta 3 as of Feb. 1, 2006.

There still appears to be a forms api issue with the buddylist group edit page. Not certain I have the forms API expertise to fix this one (mixed formdata&otherdata inside a table within a form). Function is buddylist_buddiesgroups_form - can anybody else help?

The easiest way to do that is to put the 'other data' in #type => value fields, and then put the items in a table in theme_buddylist_buddiesgroups_form().

This technique is demonstrated here

Thanks for porting this module. I move the forms comment to a page here: http://drupal.org/node/47582

Let me know if that doesn't answer your questions.

Kieran

OK, I think I figured out the technique. Applying it to this particular chunk of code turned out to be challenging. I don't claim that this is pretty code, but it now seems to work. Buddies, buddy groups, and I also fixed the SQL for displaying buddy posts. (Repeated the same post for every group the buddy is in). You really don't need to see the same post repeated over and over.

I think I'll be bold enough to call this patch 4.7 ready; though I think that claim has been made before. At least it's a launching point for the next round of bugs. Would anybody like to review it and check it in, or have all the buddylist developers jumped ship?

Sigh - all the above patches plus a fix for node/47592, a WSOD on editing buddy groups if you have no buddies. Since I was just mucking with this section of code moments ago, it wasn't too difficult to get that bug straightened out as well.

Wish I could just put this thing to rest. But as it turns out, the display of 'Buddies' names didn't make it through whatever happened with 4.7b3 last week either. So this will show an actual 'buddies' name rather than 'Object #5' or some such nonsense.

This started out as what I thought was a simple exercise in forms upgrade. Oh what fun finding bugs... many of which have been there all along.

The latest bug fix to be applied to this (now) mondo patch relates to having a buddies recent posts block, but you've lost all your buddies through some social calamity or whatever. This unfortunate event means that you don't have any buddies to populate the recent posts block. It also means that you're going to see an SQL error in the logs for every single time you access a page. This is because $str_buddies is an empty string, and therefore produces an empty parenthetical set. An empty parenthetical set in SQL is not allowed.

I've taken care of it for you...

Changing status to patch, since that's what it is (hopefully will get more attention that way).

I tested this by creating a user @ administer >> users and then adding that user as a buddy.

Now when I go to the edit groups page, I receive:

warning: implode() [function.implode]: Bad arguments. in D:\xampp\htdocs\bl-head\includes\form.inc on line 240.
warning: implode() [function.implode]: Bad arguments. in D:\xampp\htdocs\bl-head\includes\form.inc on line 240.

The groups functionality does appear to work though apart from that. Not sure if this is a momentary bug with HEAD or if it's something with the way the form is written.

In case it helps track it down, line 240 of form.inc is part of function form_get_error($element) and reads:

$key = implode('][', $element['#parents']);

The problem was that creating forms in tables is much harder now than it used to be.

Ya' got that right... Thanks!

I've fired up buddylist.patch.20060205 and I'm good to go with it. Angela, is the group edit working for you? I wasn't seeing that bug over here.

im in the airport in frankfurt... my time in the plane was spent converting this module to 4.7. will compare implementations and possibly merge patches 2morrow. too bad i didnt have internet in the pkane... would have avoided double effort.

Here's a copy. I combined several things from my work and the last patch. Fortunately, the place where the patch had done the most work was in the buddy groups area, and the biggest improvment I had made was in the add buddy/remove buddy handling.

Also changed:
-- added a setting for the other buddy block tile copy
-- minor cleanup
-- fixed a bug where the wrong variable ($userid) was being used (instead of $uid).

TODO:
-- add an install file to update for UTF-8