Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I've ported this module to Drupal 6.x for compatibility w/ Ubercart 2.x. Please see attachment for patch file. This post is duplicated at http://www.ubercart.org/issue/9389/port_drupal_6x
Please advise on the best place to post patches.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | uc_fedex.5to6.v4.diff.txt | 5.88 KB | ankur |
| #4 | uc_fedex.5to6.v3.diff.txt | 5.88 KB | ankur |
| #2 | uc_fedex.5to6.v2.diff.txt | 5.5 KB | ankur |
| uc_fedex.5to6.diff.txt | 5.39 KB | ankur |
Comments
Comment #1
tr commentedThanks. Can you re-roll the patch for the version that's currently in HEAD? I've made a number of changes since you checked it out.
My plan is to create an official release for Drupal 5 in the next few days, then branch the Drupal 5 code and work on the Drupal 6 port in HEAD.
Comment #2
ankur commentedHere's another, more current, patch. The old patch didn't apply as cleanly to the new module. I had to manually apply a couple of hunks that caused conflicts. Also, with the new theming function, there is now a hook_theme() as required by D6. Finally, the call to drupal_add_css() has been moved from hook_menu() (which is no longer called on every page load in D6) to the function that actually outputs the div with the class for which the CSS file applies.
Comment #3
tr commentedThanks. I haven't tested it yet, but I doubt the drupal_add_css() call will work where you put it because of the way shipping quotes function. Shipping quotes are invoked from JavaScript, after the page is loaded, so it's too late to add CSS to the page header. That's why this used to be done in hook_menu(). I see for the core shipping modules in D6 the CSS is now added in hook_init() because, just as you said, hook_menu() is no longer called all the time. It's still not a great solution, because then the CSS is put on every single page, while it really needs to be only on the checkout page. But the fix to that I think would involve uc_cart and maybe a new hook to allow each of the checkout panes to init themselves - to add CSS or JS for example.
Comment #4
ankur commentedComment #5
j0rd commentedThanks for this Ankur. I'll be using / testing this in the next month with some Ubercart projects.
Much appreciated.
Comment #6
z3cka commentedHow do i apply this patch? do you have a guide for applying patches? link would be greatly appreciated.
thank you.
-Casey
Comment #7
tr commentedhttp://drupal.org/patch/apply
Comment #8
ankur commentedI've noticed there's been some changes to the HEAD branch. Here's a more current patch.
Comment #9
bob.hinrichs commentedSubscribe.
Thanks TR and Ankur (we are on D6) for all of your work on this important module.
Comment #10
japerryJust tested the patch. They are working for FEDEX express shipping.
One note, we had to disable the WEEKDAY delivery options from the module, similar to this issue:
http://www.ubercart.org/forum/support/7595/fedex
Comment #11
tr commentedI posted a development release for 6.x on the main project page. It's tested and fully working as far as I can tell. I'm going to leave it up there for a little while for people to try out before I turn it into an official release. I'm going to mark this issue as "fixed" - if you have any problems with the development release please open a new issue.