I'd like to request you implement the code from the CCK API that allows the 'Printer, e-mail and PDF versions' fieldgroup to be moved around via drag-and-drop.

CommentFileSizeAuthor
#2 388008-2-Print_settings_weight.png29.67 KBAnonymous (not verified)

Comments

jcnventura’s picture

Title: Allow drag-and-drop weight in CCK » Can the print module corner links use CCK's drag-and-drop weight
Project: Printer, email and PDF versions » Content Construction Kit (CCK)
Version: 6.x-1.x-dev » 6.x-2.x-dev
Component: Code » General

Hello,

First, the 'content corner links' are not a fieldgroup, and are not created/managed by CCK. They are inserted in the content via hook_nodeapi. So I very much doubt whether that code could be implemented without making those links CCK fields. Note that the content corner links are optional and can be disabled in the settings page.

And I believe that you could probably manually create some CCK fields that replace the content corner links.

I am moving this to the CCK issue queue, so that others more knowledgeable than me about CCK can provide some input.

João

Anonymous’s picture

StatusFileSize
new29.67 KB

Ah, no sorry, I meant the fieldgroup with the 'Show link', 'Show link in individual comments' and 'Show Printer-friendly URLs list' options that appears when creating a node - the node-specific print setting (see screenshot).

As you can see, it's currently sitting between the Phone and Destinations fields, but I'd like to be able to move it down the bottom (as it's not that important), so when users go to create a new node, they don't have these print settings sitting halfway down the page, in the middle of all the important fields.

yched’s picture

Project: Content Construction Kit (CCK) » Printer, email and PDF versions
Version: 6.x-2.x-dev » 6.x-1.x-dev
Component: General » User interface

The request is that print module implements hook_content_extra_fields(), so that the 'Print' element in node forms can be reordered on CCK's 'Manage fields' tab. Right now on node forms, the 'Print' fieldset comes out randomly in the middle of the form elements that the admin reordered.

This hook lets CCK know about non CCK field additions to node and node forms.
You can look at content_content_extra_fields() in cck's content.module for an example implementation of the hook (handles core 'fields' in the name of core modules : body, title, upload...)

Anonymous’s picture

Thanks yched, your explanation sounds so much better then mine :)

jcnventura’s picture

Status: Active » Fixed

I have just committed some code to 6.x-1.x-dev that adds that hook.

João

mkrakowiak’s picture

Version: 6.x-1.x-dev » 5.x-4.4
Category: feature » bug
Status: Fixed » Active

I think this (changing the weight to 50) caused a problem in the D5 version: the Printer, e-mail and PDF versions fieldset displays underneath submit, edit, delete etc. buttons.

jcnventura’s picture

Status: Active » Postponed (maintainer needs more info)

I tested this on my site before the commit, and I have just double-checked. With or without CCK 5.10 enabled, the print fieldgroup is still above the authoring info and the publishing options.

Can this be triggered by something particular to your site?

mkrakowiak’s picture

Yes, it can definitely be triggered by something else - the site has 90 contrib modules installed. All I can tell you is that when I changed the PRINT_TYPE_FIELDS_WEIGHT variable from 50 to 25, it looks OK on content edit pages - it still shows it below the buttons on content type edit pages. BTW, I'm not 100% sure, but I think that the print options weren't available before version 5.x-4.4. I think it would be good to have a global switch for content types: whether you want to display this option on the edit pages or not.

jcnventura’s picture

The content-type print options have been around since version 2.1 and the node options since version 4.1.. The change in 4.4 was to set weights specifically. so that these appear lower in the order of fieldsets.

With so many contrib modules installed it is indeed harder to spot what else is causing the problem. Whatever it is, it seems to reduce the weights of the submit buttons. I don't know why any module would reduce those weights, so I am pretty sure that the fix would have to be done there.

I will leave this here a bit longer to see if anyone else is experiencing that problem, and if so maybe they'll have less modules installed so that the culprit is more easily found.

João

jcnventura’s picture

Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.