Drupal 6 plus it validates
peterx - March 2, 2009 - 08:11
| Project: | Ocadia |
| Version: | 5.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | stella |
| Status: | closed |
Jump to:
Description
http://d-theme.com/ocadia has a Drupal 6 version I accidentally created when testing some conversion documentation at http://d-theme.com/candy_corn. I changes only two files and they are attached. The result passed some of the validations.
| Attachment | Size |
|---|---|
| ocadia.zip | 1.94 KB |
#1
Wow, thanks! Will check it out and test it soon.
#2
Thanks @peterx, works good except I had to fix 1) below.
1) The sidebar_left and sidebar_right regions do not match the .info file (left, right).
2) The page.tpl.php has some non-code-convention-conforming php.
#3
Hello Sime,
My code conforms to conventions that predate Drupal because the code is written for easy use by many developers, contractors, and beginners. It is code-convention-conforming but in some places not drupal-code-convention-conforming-for-php.
Interestingly over the years I made several attempts to produce patches for code changes to Drupal modules and themes but the patches always failed to apply in the drupal.org system. I use multiple open source tools but they all produce different defaults and have different ranges of options. no combination produces what is required for drupal.org. Saying "standard" is like saying the Andean Condor is an example of all birds.
#4
Hi Peter. Nothing against your code, just a straight-forward review to help the maintainer and hopefully get a commit.
#5
Committed, thanks!
#6
Automatically closed -- issue fixed for 2 weeks with no activity.