Allow to override compression type by passing optional $type parameter?

Bug verified. I would add that this part of the readme file:

5. If desired, configure the module at Administer >> Site configuration >>
jQuery UI. Here you may select which level of compression the jQuery library
should use. It defaults to 'minified' compression, which strips comments and
white space.

also doesn't work. There is simply no code in the module for this.

Using the jQuery Update settings page at Administer >> Site Configuration >> jQuery Update (?q=admin/settings/jquery_update) does change the file included via jquery_ui_add(). I have tested it and it works fine.

I don't see anything about specifying the compression type in README.txt for jquery_ui. I think just having the global setting under jquery_update is enough. Is there any reason I have missed that we might want to add the compression via the function call?

Edit: Ahh.. I see it now... It was removed from the dev version. Here are the diffs showing that is the case:

• Diff of jquery_ui/README.txt 1.3 - 1.4
• Diff of jquery_ui/jquery_ui.module 1.4 - 1.5

The top paragraph still seems valid:

5. If desired, configure the module at Administer >> Site configuration >>
jQuery UI. Here you may select which level of compression the jQuery library
should use. It defaults to 'minified' compression, which strips comments and
white space.

Should this be added back (obviously with the path change mentioned in #3)?

@prajwala: Do you intend to use different compression levels for different jQuery UI files? I would think having a setting in the admin is enough to turn minification on or off depending on if you're developing the site or not. This would be enough for me and I'm guessing others but if you have a use case that might help.

If you want to get this patch committed you will need to follow Drupal's coding standards.

I'm not sure this makes sense in any way.

Anyway, I'll reconsider later.

+function jquery_ui_add($files = array(), $compression_type = False) {

Constants are all uppercase in Drupal.

+  $compression = $compression_type ? $compression_type : variable_get('jquery_update_compression_type', 'mini');

Please wrap this (entire) ternary operator condition in braces, clarifying where the condition starts and ends, i.e. after the equal sign and before the semicolon.

I thought that the ternary operator has precedence over the assignment operator; if that is the case, the parenthesis are not necessary (or sun is talking of something else, and I have not understood what he meant).

I don't think that allowing any third-party modules to decide the type of compression is something that makes sense; it should be the administrator users to decide the used compression, basing on the files they copied.

I agree, this does not make sense. You can override the compression type via the administrative settings or by overriding the variable via settings.php on your development/staging site.

Also, README.txt no longer states that one is able to do this anyway - which means this option was removed as part of another issue (probably bug report).

Just in case someone wonders :
variable_get('jquery_update_compression_type', 'mini');

=> for the jquery_update module version I am using (2.0-alpha1), this variable will never take the 'mini' value, only 'min'

So testing the value 'mini' for the variable $compression may be useless