The theme function theme_permalink_node() creates an incorrect and possibly unsafe link to http:// $_SERVER['HTTP_HOST']. The base path is not taken into consideration here. IMHO the theme function should use the global $base_url for the first part of the permalink.

Comments

todd nienkerk’s picture

todd nienkerk commented
Assigned: Unassigned » todd nienkerk

Agreed.

The 6.x branch uses url() instead of assembling the URL more or less manually. I'll see if I can backport it.

todd nienkerk’s picture

todd nienkerk commented
Title: incorrect permalink with HTTP_HOST » Incorrect permalink with HTTP_HOST

Handy link: usage of $base_url in Drupal 5.x.

todd nienkerk’s picture

todd nienkerk commented

Fixed in 5.x-1.2.

todd nienkerk’s picture

todd nienkerk commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.