Bookmarks to include Query strings

what do you mean with some issues?

i would like to solve this problem here

the menu system can save this kind of links

Thanks for this awesome module, darthclue :)

This isn't quite fixed though.

If I try to save this:
http://example.com/contacts?group[]=1&country=South+Africa&name=Norio&lastname=De+Sousa

It gets saved as this:
http://example.com/contacts?&group=Array&country=South%20Africa&name=Norio&lastname=De%20Sousa

I solved it by replacing this: (bookmarks.module; Lines: 296-299)

$query_string = '';
foreach ($query_variables as $key => $value) {
  $query_string .= '&' . $key . '=' . $value;
}

With this:

$query_string = preg_replace("/q=[^&]+&/", "", $_SERVER["QUERY_STRING"]);

It's probably not the best way to do it but it works.

I also noticed a problem with your redirect when query strings are involved.

See:
http://drupal.org/node/247585#comment-1433480

I solved it by replacing this: (bookmarks.admin.inc; Lines: 495-498)

//If the redirect_after value is set, send them there.
if ($item['redirect_after']) {
  $form_state['redirect'] = $item['redirect_after'];
}

With this:

//If the redirect_after value is set, send them there.
if ($item['redirect_after']) {
  list($redirect_path, $redirect_query) = explode("?", $item['redirect_after']);
  $form_state['redirect'] = array($redirect_path, $redirect_query);
}

Works perfectly now :) Thanks again for the cool module!

PS: There are some security problems, too. Specifically, SQL queries where you're not using '%d' and '%s', etc. Just a heads-up.

I am using Bookmarks version 6.x-2.9 and am have discovered that the Add this page function does not work when a query string is included. The following search will work: example.com/search/apachesolr_search/dropout however these next two will not:
1) example.com/search/apachesolr_search/dropout prevention (nor dropout%20prevention)
2) example.com/search/apachesolr_search/"dropout prevention"

I am not sure if making the changes that norio above suggests will work or are prudent.

I too find it interesting that I have search for a while and this is the first mention of this problem. We have had the module for only 2 weeks.

This feature would make the bookmarks module extremely useful for us.

thank you

Why did you just close this? It isn't working.

Open a new issue then.